Last modified: 2013-11-05 19:03:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52635, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50635 - SiteStats shows 0 for job queues not using database
SiteStats shows 0 for job queues not using database
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JobQueue (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/w/api.php?ac...
:
: 51163 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-03 02:57 UTC by Matthew Flaschen
Modified: 2013-11-05 19:03 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-07-03 02:57:47 UTC
SiteStats uses:

self::$jobs = $dbr->estimateRowCount( 'job' );

which simply shows 0 if the job queue doesn't use that table (e.g. for the Redis queue).

Example: https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=statistics shows jobs="0"
Comment 1 MZMcBride 2013-07-03 03:00:44 UTC
Dupe of bug 9518?
Comment 2 Matthew Flaschen 2013-07-03 03:05:55 UTC
I don't think so.  Let's keep that specifically for relational databases (specifically, it seems to boil down to Rob Church's note, "The job queue count shown on Special:Statistics is generated using a clever
trick which avoids an expensive COUNT(*) on the job table. This trick means
that the value will fluctuate, often to the point where it's downright
incorrect.").

The current Redis job queue implementation is totally different (doesn't use a relational database and takes advantage of Redis-specific features).
Comment 3 Gerrit Notification Bot 2013-07-04 07:26:19 UTC
Change 71966 had a related patch set uploaded by Aaron Schulz:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966
Comment 4 Matthew Flaschen 2013-07-12 03:00:39 UTC
*** Bug 51163 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2013-10-01 03:23:49 UTC
Change 71966 merged by jenkins-bot:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links