Last modified: 2014-02-12 16:43:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52645, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50645 - VisualEditor: Resizing an image which doesn't already have an explicit size set doesn't work


Summary:	VisualEditor: Resizing an image which doesn't already have an explicit size s...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2013-07-18
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Duplicates:	51026 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-03 08:36 UTC by Oliver Keyes
Modified:	2014-02-12 16:43 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Oliver Keyes 2013-07-03 08:36:18 UTC

What it says on the tin; if you resize an image, it with reports "this isn't a change, can't save" or saves and silently doesn't do anything.

Comment 1 Gerrit Notification Bot 2013-07-16 14:09:01 UTC

Change 73965 had a related patch set uploaded by Esanders:
Create MWResizeableNode mixin to control defaultSize flag

https://gerrit.wikimedia.org/r/73965

Comment 2 Gerrit Notification Bot 2013-07-16 22:51:26 UTC

Change 73965 merged by jenkins-bot:
Create MWResizeableNode mixin to control defaultSize flag

https://gerrit.wikimedia.org/r/73965

Comment 3 James Forrester 2013-07-16 23:06:19 UTC

Fixed and will be going out in a few minutes.

Comment 4 James Forrester 2013-07-18 00:18:04 UTC

*** Bug 51026 has been marked as a duplicate of this bug. ***

Comment 5 Maggie Dennis 2014-02-12 14:12:43 UTC

I'm not sure if this is the same issue, but as reported on English Wikipedia and tested by myself, using the image resizer to "Make full size" resulted in either a notice that no change had been made or a silent failure to save.

This was tested on FF26, W7 and Chrome 32.0.1700.107 m, W7. 

The reporting editor concludes that "These new settings, for what they are worth, only work if the image already has a size indication (200px, 250px*250px, whatever), not when it only has a 'thumb' indication. Sadly, the latter is the default and by far most common situation."

He also questions the purpose of "Make full size", but I'll report that separately. 

See: https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=595141503#Advanced_image_settings.3F_More_VisualEditor_rubbish.

Comment 6 Ed Sanders 2014-02-12 16:43:12 UTC

Moved to bug 61270

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links