Last modified: 2014-02-03 16:23:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52660, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50660 - in Firefox, search icon is not aligned properly
in Firefox, search icon is not aligned properly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.0
PC Linux
: High minor (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-03 13:13 UTC by Sage Ross
Modified: 2014-02-03 16:23 UTC (History)
2 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
misaligned search icon in search box (237.49 KB, image/png)
2013-07-03 13:13 UTC, Sage Ross
Details

Description Sage Ross 2013-07-03 13:13:06 UTC
Created attachment 12740 [details]
misaligned search icon in search box

Since yesterday on all wikis (so possibly related to the Universal Language Selector?) the search icon within the top right search box has shifted down, so that it crosses the edge of the search box (instead of being centered vertically within it).

This bug is only present for me with Firefox (21.0), not Chromium.
Comment 1 Andre Klapper 2013-07-03 14:41:06 UTC
I think I've seen this for longer than yesterday, however setting high prio in case it's really a regression.
Comment 2 Sage Ross 2013-07-03 14:45:49 UTC
Could be older. I noticed it yesterday, but may have overlooked it earlier.
Comment 3 Bartosz Dziewoński 2013-07-03 14:50:26 UTC
I am unable to reproduce using Firefox 21, on mw.org, en.wp and my own test wiki.
Comment 4 Sage Ross 2013-07-03 14:55:30 UTC
I occurs for me on different Linux computers, with both FF 21 and FF 22, on all Wikimedia sites (whether logged in or logged out).
Comment 5 Bartosz Dziewoński 2013-10-18 19:51:54 UTC
Still happens? Because it still doesn't happen for me :)
Comment 6 Sage Ross 2013-10-18 20:34:48 UTC
Yes. On my current setup, with with FF24, it looks like it's not as dramatic as before. The search icon is lower than it should be at the default zoom level, but it only extends past the bottom of the search box if I shrink the zoom level to 90% or lower.

On Chromium, it is aligned properly at all zoom levels.
Comment 7 Bartosz Dziewoński 2013-10-18 21:22:49 UTC
Gah. Can you test https://gerrit.wikimedia.org/r/#/c/82100/ for me and see if it solves the issue by chance? It's a larger patch to redo the search box on Vector.

(I temporarily deployed it on http://users.v-lo.krakow.pl/~matmarex/testwiki/ , you can test there if you don't have a local wiki to try on.)
Comment 8 Sage Ross 2013-10-18 21:29:52 UTC
The bug is not present on your test wiki. :)
Comment 9 Gerrit Notification Bot 2013-10-18 22:12:35 UTC
Change 82100 had a related patch set uploaded by Bartosz Dziewoński:
Rewrite rendering of Vector simple search

https://gerrit.wikimedia.org/r/82100
Comment 10 Gerrit Notification Bot 2014-02-03 02:30:31 UTC
Change 82100 merged by jenkins-bot:
Rewrite rendering of Vector simple search

https://gerrit.wikimedia.org/r/82100

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links