Last modified: 2013-08-01 09:56:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52689, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50689 - string length of string data values is not checked in create claim api module
string length of string data values is not checked in create claim api module
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-03 19:40 UTC by Aude
Modified: 2013-08-01 09:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-07-03 19:40:14 UTC 
even though we now have validators (particularly for max string length 400 and trailing/leading whitespace) registered in a data type builder class, I can create string data values with length 2000+ and whitespace padding with the create claim api module.
Comment 1 Aude 2013-07-03 19:40:28 UTC 
the issue occurs in master, btw
Comment 2 Daniel Kinzler 2013-07-03 19:41:17 UTC 
fix pending review: I49216858fa1b077
Comment 3 Gerrit Notification Bot 2013-07-03 19:42:05 UTC 
Change 71863 had a related patch set uploaded by Daniel Kinzler:
Add snak validation to wbcreateclaim module.

https://gerrit.wikimedia.org/r/71863
Comment 4 Addshore 2013-07-22 08:58:27 UTC 
https://gerrit.wikimedia.org/r/#/c/71863/

Patch Merged
Comment 5 abraham.taherivand 2013-08-01 09:56:32 UTC 
Verified in Wikidata demo July 31th.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links