Last modified: 2013-07-10 23:03:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52715, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50715 - VisualEditor: Transclusion dialog sometimes shows items in "Add parameter" that are already used


Summary:	VisualEditor: Transclusion dialog sometimes shows items in "Add parameter" th...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Highest normal
Target Milestone:	VE-deploy-2013-07-11
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:	code-update-regression

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-04 04:01 UTC by Krinkle
Modified:	2013-07-10 23:03 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot of problem (123.06 KB, image/png) 2013-07-04 04:01 UTC, Krinkle	Details
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-07-04 04:01:21 UTC

Created attachment 12749 [details]
Screenshot of problem

This causing:

* The label fallback (parameter name + ucfirst) not working.
* It is still available from the "Add parameter" dropdown.
* The user can actually add it again, causing a logic error.

I can currently consistently reproduce this on https://en.wikipedia.org/wiki/Taal%2C_Batangas?veaction=edit when editing the "Population Consensus of Taal" information box.

See screenshot:
- "title" is both in the sidebar and in the selectable cloud
- "title" isn't transformed into "Title" (the templatedata has no .label for this one)

Comment 1 Gerrit Notification Bot 2013-07-10 19:06:55 UTC

Change 73010 had a related patch set uploaded by Trevor Parscal:
Retain original param names and ignore leading/trailing whitespace

https://gerrit.wikimedia.org/r/73010

Comment 2 Gerrit Notification Bot 2013-07-10 22:57:53 UTC

Change 73010 merged by jenkins-bot:
Retain original param names and ignore leading/trailing whitespace

https://gerrit.wikimedia.org/r/73010

Comment 3 James Forrester 2013-07-10 23:03:27 UTC

This is now fixed in master and we will push to production very soon. Sorry for the inconvenience.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links