Last modified: 2013-07-23 21:57:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52716, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50716 - Second sequential edit raises warning
Second sequential edit raises warning
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 04:36 UTC by John Mark Vandenberg
Modified: 2013-07-23 21:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of warning (24.81 KB, image/png)
2013-07-04 04:38 UTC, John Mark Vandenberg
Details

Description John Mark Vandenberg 2013-07-04 04:36:15 UTC
Steps to reproduce
1. Edit page with VE and add {{fact}}, and save page with VE.
2. Wait until a bot adds parameters to {{fact}}
3. Click 'Edit', starting the VE.

(I suspect that step 2 is not a mandatory part of the process)

Result:
Red warning with text that can not be copied: "You are editing an old revision of this page. If you save it, any changes since then will be lost."

The warning can be dismissed.

The 'Edit' button at the top of the page does nothing.  Control-clicking 'Edit' in Firefox does open VE in a new tab.

(There is no apparent option to get a current revision of the page)

Expected result 1:
As the user has not started editing yet, they should be offered the option of starting editing again.

Expected result 2:
MediaWiki has edit conflict resolution, both manual (view diff and edit) and automated.  The VE warning should not "If you save it, any changes since then will be lost."  It should politely inform the user that they will need to merge those "any changes" into the new revision before saving.  And the VE should give them a nice pretty interface to help them resolve the conflicts (and a unicorn too).
Comment 1 John Mark Vandenberg 2013-07-04 04:38:40 UTC
Created attachment 12750 [details]
Screenshot of warning
Comment 2 John Mark Vandenberg 2013-07-04 04:51:34 UTC
I think the message "You are editing an old revision of this page. If you save it, any changes since then will be lost." is provided by a English Wikipedia message.

The message also appears when intentionally editing an old revision
(e.g. https://en.wikipedia.org/w/index.php?title=Walla!&action=edit&oldid=446460629)

Sorry to add what is probably also another existing bug:
Clicking edit on an old revision launches VE with the current revision rather than the specified revision.
i.e. goto https://en.wikipedia.org/w/index.php?title=Walla!&oldid=446460629 and click 'Edit'
Comment 3 John Mark Vandenberg 2013-07-23 21:57:28 UTC
The problem has been fixed.  Cant be bothered finding the bug it was fixed under.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links