Last modified: 2013-07-17 14:23:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52718, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50718 - sites table got cleared on beta labs clients
sites table got cleared on beta labs clients
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Unprioritized critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 06:07 UTC by Aude
Modified: 2013-07-17 14:23 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2013-07-04 06:07:03 UTC
Somehow, the sites table got cleared (e.g. truncated) last night on beta lab client wikis, such as http://en.wikipedia.beta.wmflabs.org/

It caused a stack trace. (see below)

the timing of this is suspiciously coincidental with the merging of Wikibase patches that touched the LangLinkHandler:

https://gerrit.wikimedia.org/r/#/c/71302/

https://gerrit.wikimedia.org/r/#/c/71322/

Need to find out from hashar if some tests are being run there or what, and try to figure out what caused this to happen.

2013-07-03 22:03:41 deployment-apache32 enwiki: [ba44362a] /wiki/0.4228940863319691_Moved   Exception from line 463 of /data/project/apache/common-local/php-master/extensions/Wikibase/client/includes/LangLinkHandler.php: Unable to resolve site ID 'enwiki'!
#0 /data/project/apache/common-local/php-master/extensions/Wikibase/client/includes/LangLinkHandler.php(396): Wikibase\LangLinkHandler->getSiteGroup()
#1 /data/project/apache/common-local/php-master/extensions/Wikibase/client/includes/LangLinkHandler.php(428): Wikibase\LangLinkHandler->getEffectiveRepoLinks(Object(Title), Object(ParserOutput))
#2 /data/project/apache/common-local/php-master/extensions/Wikibase/client/WikibaseClient.hooks.php(370): Wikibase\LangLinkHandler->addLinksFromRepository(Object(Title), Object(ParserOutput))
#3 [internal function]: Wikibase\ClientHooks::onParserAfterParse(Object(Parser), 'Starting a new ...', Object(StripState))
#4 /data/project/apache/common-local/php-master/includes/Hooks.php(199): call_user_func_array('\Wikibase\Clien...', Array)
#5 /data/project/apache/common-local/php-master/includes/GlobalFunctions.php(3829): Hooks::run('ParserAfterPars...', Array)
#6 /data/project/apache/common-local/php-master/includes/parser/Parser.php(387): wfRunHooks('ParserAfterPars...', Array)
#7 [internal function]: Parser->parse('Starting a new ...', Object(Title), Object(ParserOptions), true, true, 57677)
#8 /data/project/apache/common-local/php-master/includes/StubObject.php(79): call_user_func_array(Array, Array)
#9 /data/project/apache/common-local/php-master/includes/StubObject.php(99): StubObject->_call('parse', Array)
#10 /data/project/apache/common-local/php-master/includes/content/WikitextContent.php(300): StubObject->__call('parse', Array)
#11 /data/project/apache/common-local/php-master/includes/content/WikitextContent.php(300): StubObject->parse('Starting a new ...', Object(Title), Object(ParserOptions), true, true, 57677)
#12 /data/project/apache/common-local/php-master/includes/WikiPage.php(3426): WikitextContent->getParserOutput(Object(Title), 57677, Object(ParserOptions))
#13 /data/project/apache/common-local/php-master/includes/PoolCounter.php(222): PoolWorkArticleView->doWork()
#14 /data/project/apache/common-local/php-master/includes/Article.php(708): PoolCounterWork->execute()
#15 /data/project/apache/common-local/php-master/includes/actions/ViewAction.php(44): Article->view()
#16 /data/project/apache/common-local/php-master/includes/Wiki.php(439): ViewAction->show()
#17 /data/project/apache/common-local/php-master/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#18 /data/project/apache/common-local/php-master/includes/Wiki.php(565): MediaWiki->performRequest()
#19 /data/project/apache/common-local/php-master/includes/Wiki.php(458): MediaWiki->main()
#20 /data/project/apache/common-local/php-master/index.php(55): MediaWiki->run()
#21 /data/project/apache/common-local/w/index.php(3): require('/data/project/a...')
Comment 1 Aude 2013-07-04 06:11:01 UTC
I was able to repopulate it there, btw.
Comment 2 Aude 2013-07-04 09:26:44 UTC
after investigating, I figured out that the sites table never was populated for the wikipedia beta sites.

Before https://gerrit.wikimedia.org/r/#/c/71302/ was merged, the code only gave a php warning about not being able to find sites.  As far as I can tell, php warnings are not logged on beta.

Now it gives an exception, which we should handle, but at the same time log somewhere prominently so we are aware.

The beta instances are really not yet configured to get data from wikidata beta (and won't get data from the real wikidata). 

Thus, there was no expectation to see "external" wikidata links in the sidebar etc. on beta wikipedia anyway, and we would not have noticed the issue.
Comment 3 Aude 2013-07-04 09:27:46 UTC
ps, note that the site_domain column looks improperly populated with just a "."

I am not sure why....

stdClass Object
(
    [site_id] => 13
    [site_global_key] => hewiki
    [site_type] => mediawiki
    [site_group] => wikipedia
    [site_source] => local
    [site_language] => he
    [site_protocol] => 
    [site_domain] => .
    [site_data] => a:1:{s:5:"paths";a:2:{s:9:"file_path";s:36:"//he.wikipedia.beta.wmflabs.org/w/$1";s:9:"page_path";s:39:"//he.wikipedia.beta.wmflabs.org/wiki/$1";}}
    [site_forward] => 0
    [site_config] => a:0:{}
)
Comment 4 Aude 2013-07-04 09:34:06 UTC
see https://bugzilla.wikimedia.org/50729 and https://bugzilla.wikimedia.org/50730  for the related issues.
Comment 5 abraham.taherivand 2013-07-17 14:23:20 UTC
Verified in Wikidata demo time July 17th

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links