Last modified: 2014-01-12 14:37:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52796, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50796 - Use [[MediaWiki:MediaWiki:Parentheses]] instead of hardcoded parentheses


Summary:	Use [[MediaWiki:MediaWiki:Parentheses]] instead of hardcoded parentheses

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	AbuseFilter (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Tony Thomas

URL:
Whiteboard:
Keywords:	easy, i18n

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-05 12:16 UTC by Helder
Modified:	2014-01-12 14:37 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2013-07-05 12:16:34 UTC

I believe the extension should use [[MediaWiki:MediaWiki:Parentheses]] instead of hardcoding the parenthesis on this line[1]:
------------------------------------------
		$s .= " ($examineLink)";
------------------------------------------

Is that right?

[1] https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/f10b8eaab546580e3134c0dc116686f72b718828/Views/AbuseFilterView.php#L87

Comment 1 Gerrit Notification Bot 2014-01-12 09:34:38 UTC

Change 107020 had a related patch set uploaded by 01tonythomas:
Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses

https://gerrit.wikimedia.org/r/107020

Comment 2 Gerrit Notification Bot 2014-01-12 14:36:13 UTC

Change 107020 merged by jenkins-bot:
Used [[MediaWiki:Parentheses]] instead of hardcoded parentheses

https://gerrit.wikimedia.org/r/107020

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links