Last modified: 2013-07-11 16:12:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52801, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50801 - VisualEditor: Changing templates makes wikilinks ([[Foo|Bar]]) render as raw wikitext instead of parsed


Summary:	VisualEditor: Changing templates makes wikilinks ([[Foo\|Bar]]) render as raw ...

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Data Model (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2013-07-11
Assigned To:	Ed Sanders

URL:	https://de.wikipedia.org/wiki/VRB_H_2/3
Whiteboard:
Keywords:

Duplicates:	50909 51014 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-05 13:14 UTC by Raimond Spekking
Modified:	2013-07-11 16:12 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Template inspector before closing (152.66 KB, image/png) 2013-07-05 13:14 UTC, Raimond Spekking	Details
Template inspector after closing (163.28 KB, image/png) 2013-07-05 13:15 UTC, Raimond Spekking	Details
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2013-07-05 13:14:58 UTC

Created attachment 12760 [details]
Template inspector before closing

Wikilinks like [[Foo|Bar]] are shown expanded in template inspector after closing it, see screenshots. 

Steps to reproduce:

1. Edit a template which has wikilinks like [[Foo|Bar]] as a parameter value
2. Close the template inspector, with or w/o changes does not matter.

Comment 1 Raimond Spekking 2013-07-05 13:15:18 UTC

Created attachment 12761 [details]
Template inspector after closing

Comment 2 This, that and the other (TTO) 2013-07-09 07:16:26 UTC

*** Bug 50909 has been marked as a duplicate of this bug. ***

Comment 3 James Forrester 2013-07-11 05:38:15 UTC

*** Bug 51014 has been marked as a duplicate of this bug. ***

Comment 4 Ed Sanders 2013-07-11 11:57:40 UTC

Can't reproduce this at the example URL.

Comment 5 Raimond Spekking 2013-07-11 12:10:52 UTC

(In reply to comment #4)
> Can't reproduce this at the example URL.

I can still reproduce it :-(

Comment 6 Oliver Keyes 2013-07-11 12:15:03 UTC

As can I, hence the duplicate bugs. Firefox 22, Windows 7.

Comment 7 Ed Sanders 2013-07-11 12:49:24 UTC

Can you create a broken diff on that article for me?

Comment 8 Krinkle 2013-07-11 12:50:49 UTC

It doesn't show in the diff, it only shown in the live rendering in VisualEditor.

Comment 9 Krinkle 2013-07-11 12:54:06 UTC

Screenshot of different phases:

http://cl.ly/image/1X0I281n1n0G
1) PHP rendering on Read
2) VE initial rendering after Edit
3) VE rendering after opening Template dialog and making no changes and clicking Apply changes

Dirty diff: http://cl.ly/image/241h1I3T1d2d

Comment 10 Ed Sanders 2013-07-11 14:33:54 UTC

This is a wikitext escaping bug in VE

Comment 11 Gerrit Notification Bot 2013-07-11 14:46:14 UTC

Change 73173 had a related patch set uploaded by Esanders:
Piped links in wikitext parameters getting escaped

https://gerrit.wikimedia.org/r/73173

Comment 12 Gerrit Notification Bot 2013-07-11 16:06:00 UTC

Change 73173 merged by jenkins-bot:
Prevent escaping of piped links in wikitext parameters

https://gerrit.wikimedia.org/r/73173

Comment 13 James Forrester 2013-07-11 16:12:57 UTC

We've now fixed this in master, and will back-port to production.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links