Last modified: 2014-01-05 16:18:44 UTC
When a user visits a page such as [[Special:AbuseLog/9999]] the extension adds two links: ------------------------------------------------------------ 18:01, 19 March 2009: 119.94.161.169 (talk) triggered filter 30, performing the action "edit" on Database. Actions taken: Warn; Filter description: Large deletion from article by new editors (details | examine) ------------------------------------------------------------ The link whose text is "details" points to that same page, so it is just cluttering the interface.
Hello, I am a beginner and would like to work on this bug. Can somebody assign it to me?
Please see http://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/Developer_access . The codebase is at https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FAbuseFilter.git
Created attachment 13612 [details] I have commented the line so that the actionLinks does not have the detailsLink.
Hi! Thanks for your patch! Please use Developer access https://www.mediawiki.org/wiki/Developer_access to submit this as a Git branch directly into Gerrit: https://www.mediawiki.org/wiki/Git/Tutorial Putting your branch in Git makes it easier to review it quickly. Thanks again! We appreciate your contribution.
Why comment and not remove the line entirely if its not required?
Well while trying to fix the bug, I was not sure if this is the correst patch or not. Hence I decided to just commment the line and not remove it completely
Ok. As Andre said please try using Git and Gerrit to submit a patch. It will be reviewed there so you can remove it if needed.
Well I tried to work with Git and Gerrit to submit the patch. But I am unable to submit a patch. $git review -R ssh: connect to host gerrit.wikimedia.org port 29418: Connection timed out fatal: The remote end hung up unexpectedly I always get this error so unable to submit the patch
Might be bug 56034 comment 8 - might work after a few times of re-trying.
Well I tried it a few times. In the main directory there exists a .git/ directory and .gitreview file, but still git review -R does not work.
Change 105164 had a related patch set uploaded by 01tonythomas: Removed the "details" link if the user is already in details page https://gerrit.wikimedia.org/r/105164
Change 105164 merged by jenkins-bot: Removed the "details" link if the user is already in details page https://gerrit.wikimedia.org/r/105164
