Last modified: 2013-08-27 16:46:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52820, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50820 - CentralNotice should not be displayed in print view
CentralNotice should not be displayed in print view
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Adam Wight
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-05 18:51 UTC by Peter Coombe
Modified: 2013-08-27 16:46 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Coombe 2013-07-05 18:51:53 UTC 
Can't see any use case for it, and it causes problems with our fundraising facts banners overlapping the text.
Comment 1 Matt Walker 2013-07-05 19:00:00 UTC 
Apparently this also causes banner to be shown on mobile devices... (when viewed in print view...)
Comment 2 Adam Wight 2013-07-31 00:24:52 UTC 
https://gerrit.wikimedia.org/r/76863
Comment 3 Adam Wight 2013-07-31 00:25:21 UTC 
There are other interesting cases such as screen-readers, but we'll rebuild those bridges as needed.
Comment 4 Andre Klapper 2013-08-27 16:03:32 UTC 
(In reply to comment #2)
> https://gerrit.wikimedia.org/r/76863

Patch got merged. Closing bug report as FIXED, but please reopen if more work is needed (and elaborate).
Comment 5 Matt Walker 2013-08-27 16:46:34 UTC 
For the record; the patch will 'just work' for banners that do not autohide (e.g. will not work for fundraising banners.)

Banners that do autohide/display will need to add either a window.matchMedia() query; or detect if printable=yes -- and if in print mode not display themselves.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links