Last modified: 2013-07-06 14:31:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52833, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50833 - [SF] Default values incorrectly applied when editing existing pages
[SF] Default values incorrectly applied when editing existing pages
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-05 20:04 UTC by Jamie Thingelstad
Modified: 2013-07-06 14:31 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jamie Thingelstad 2013-07-05 20:04:56 UTC
I just did an update from master and did a form edit with bad results. It looks like the current master (a3d5b54b47365c3b8f7b13ae6289473464442cec) doesn't want to keep all current template values. Using that commit resulted in a very bad form edit that didn't read any of the current values. The Edit with Form screen reverted to defaults instead of using the current values.

Reverting to (2e5567a1e8f6df84c3879e19e4a4805248731be1) resolved the issue
Comment 1 Jamie Thingelstad 2013-07-05 20:07:31 UTC
Note, this is the diff of the bad edit. It's a little confusing because some of these fields I did change:

http://wikiapiary.com/w/index.php?title=Ultipedia&diff=273776&oldid=260530

Note that Audited, Active values should *not* have changed.

Also, the form edit screen didn't have the Image in it.

I used "undo" on that change, then reverted to the previous commit and did the same edit and worked as expected.

http://wikiapiary.com/w/index.php?title=Ultipedia&diff=273779&oldid=273778
Comment 2 Yaron Koren 2013-07-05 21:02:21 UTC
I changed the title from "Semantic Forms master loses current form/template values" to "[SF] Some Boolean values change from "Yes" to "No"".

What's "the Image" that you're talking about?
Comment 3 Jamie Thingelstad 2013-07-05 21:41:11 UTC
The field

{{{field|Image|uploadable|image preview|default=Default website image.png}}}

on this form

http://wikiapiary.com/wiki/Form:Website

also reverted back to default when edited with the current master.
Comment 4 Jamie Thingelstad 2013-07-05 21:46:55 UTC
I checked out master again, did Edit with Form and then did a Show Changes to see what it was not keeping (without editing anything). It lost values in text fields and checkboxes. It seems like the ones that lost value are mostly (maybe all) ones that have defaults specified.
Comment 5 Yaron Koren 2013-07-05 21:59:29 UTC
That makes sense - I retitled it again.
Comment 6 Jamie Thingelstad 2013-07-05 22:10:19 UTC
Yep, sorry for the confusion.
Comment 7 Yaron Koren 2013-07-05 22:12:48 UTC
I think this is fixed now; thanks for the bug report.
Comment 8 Jamie Thingelstad 2013-07-06 14:31:50 UTC
I pulled 8add8efadb8976c5dafb34870a9dc5039e13cbc5 and verified that the defaults are not being applied on an existing value.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links