Last modified: 2013-07-27 00:17:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52838, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50838 - Uploading draft patch sets to non-draft changes -- no submit button visible
Uploading draft patch sets to non-draft changes -- no submit button visible
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-05 20:58 UTC by christian
Modified: 2013-07-27 00:17 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description christian 2013-07-05 20:58:15 UTC
It is currently possible to upload draft patch sets to non-draft
changes in gerrit.

Hence for changes, where the most recent patch set is a draft, no
submit button is shown, which causes confusion for users. Especially,
for those who could submit but cannot see drafts. Such users cannot
easily identify that the (non-visible) most recent (draft) patch set
is prohibiting the submission.

Do we use the possibility of submitting draft patch sets to non-draft
changes. If so, is it worth the trouble it is causing for reviewers?
Comment 1 Gerrit Notification Bot 2013-07-05 20:59:13 UTC
Change 72149 had a related patch set uploaded by QChris:
Prohibit uploading draft patch sets to non-draft changes

https://gerrit.wikimedia.org/r/72149
Comment 2 christian 2013-07-05 21:01:28 UTC
Upstream says that uploading draft changes to non-draft changes is a feature,
although it for example mangles Submit Type, and gives stream events consumers
(Jenkins, ...) a hard time to detect when a patch set is a draft and when it's
not.
Comment 3 Chad H. 2013-07-05 21:03:23 UTC
(In reply to comment #2)
> Upstream says that uploading draft changes to non-draft changes is a feature,

Upstream isn't allowed to have opinions on drafts anymore. Completely useless feature...wish it just didn't exist.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links