Last modified: 2013-07-12 02:43:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52851, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50851 - guider shows pointing arrow when attachTo element isn't present
guider shows pointing arrow when attachTo element isn't present
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: spage
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-06 05:37 UTC by spage
Modified: 2013-07-12 02:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-07-06 05:37:31 UTC
If a tour definition step has
   attachTo: '.NoSuchSelector',

and the attachTo element isn't on the page, the tour is positioned in the center of the window (fine), but the guider still shows the position triangle pointing to the non-existent element.  I think the problem is the missing attachTo only affects the CSS returned by _getAttachCss(), it should also affect the later _styleArrow() and also maybe the flip behavior.

One workaround is for JS code to detect if the element is not present and modify the tour to either skip the step or not set position; another is to use the failStep property.
Comment 1 Gerrit Notification Bot 2013-07-06 05:47:52 UTC
Change 72241 had a related patch set uploaded by Spage:
Don't show position arrow if no attachTo found

https://gerrit.wikimedia.org/r/72241
Comment 2 Gerrit Notification Bot 2013-07-12 02:43:04 UTC
Change 72241 merged by Mattflaschen:
Don't show position arrow if no attachTo found

https://gerrit.wikimedia.org/r/72241

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links