Last modified: 2013-10-28 17:04:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52857, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50857 - #coordinates doesn't seem to understand type:city(<integer>)
#coordinates doesn't seem to understand type:city(<integer>)
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
GeoData (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-06 10:13 UTC by Maarten Dammers
Modified: 2013-10-28 17:04 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2013-07-06 10:13:58 UTC
For type:city it's common to include the number of inhabitants after it, so for example type:city(146753). This is useful for seeing the difference between small and large cities. At the moment this is not parsed and gt_type is set to null. 

This should be parsed and stored in the geo_tags table. Two options:
* Store it as "city(146753)"
* Strip off the (146753) part and only store "city"

Either is fine with me
Comment 1 Max Semenik 2013-07-06 20:15:54 UTC
Hmm, funny - we even have tests that are supposed to verify that the latter works - however in practice it doesn't work:P
Comment 2 Maarten Dammers 2013-07-08 13:53:54 UTC
We need unit tests to tests the unit tests? ;-)
Comment 3 Max Semenik 2013-10-07 21:06:57 UTC
https://en.wikipedia.org/w/index.php?title=User:MaxSem/sandbox&oldid=576195752 results in the following:

{
    "query": {
        "pages": {
            "34832133": {
                "pageid": 34832133,
                "ns": 2,
                "title": "User:MaxSem/sandbox",
                "coordinates": [
                    {
                        "lat": 45.7572,
                        "lon": 21.2336,
                        "type": "city",
                        "dim": "10000",
                        "globe": "earth"
                    }
                ]
            }
        }
    }
}

WORKSFORME? But I remeber it indeed had some problems when I first investigated it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links