Last modified: 2013-07-07 18:04:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52869, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50869 - Filter does not detect new links when a page is created
Filter does not detect new links when a page is created
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
REL1_21-branch
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-06 20:10 UTC by Kazimierz
Modified: 2013-07-07 18:04 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kazimierz 2013-07-06 20:10:25 UTC
I am trying to prevent untrusted users from adding external links to pages on my wiki. I have created the filter with these conditions:

(length(added_links) > 0) & !('trusted_user' in user_groups)

and it matches all old edits that I would like to block. During testing it also blocks adding new links to existing pages.

But it fails to block creation of a new page containing external links (hit count is not increased). Maybe I am doing something wrong. I have tried the (length(added_links) > 0) alone, and it is the same. I also tried (length(all_links) > 0) with the same result: new users still can create pages containing external links. In the 'examination' all the filter condition versions perfectly match the modifications they should have blocked. 

I have also tried (new_size > 0) and this one works fine (new page creations are blocked).

I have these settings for Emergency Disable feature (effectively turning it off, hopefully):
$wgAbuseFilterEmergencyDisableThreshold['default'] = 1;
$wgAbuseFilterEmergencyDisableCount['default']     = 100;
$wgAbuseFilterEmergencyDisableAge['default']       = 1;

I can provide an account to my wiki for someone to test it, if necessary. I had to disable creation of new users and anonymous editing because of spam.
Comment 1 Kazimierz 2013-07-07 10:51:37 UTC
First quick checks show that EditFilterMergedContent (MW 1.21) hook is not triggered on a new page creation, when the added_links filter is the only one active. It is triggered when the new_size filter is active. I will look deeper into it when I have more time.
Comment 2 db [inactive,noenotif] 2013-07-07 12:45:36 UTC
looks related: Gerrit change #67043
Comment 3 Marius Hoch 2013-07-07 14:59:17 UTC
The linked change should have fixed that. If this still occurs on the master of AbuseFilter, please reopen the bug.
Comment 4 Kazimierz 2013-07-07 18:04:43 UTC
It's fixed. Thank you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links