Last modified: 2013-08-29 00:01:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52905, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50905 - VisualEditor: Transclusion icon appears on the opposite side of the page in RTL wikis
VisualEditor: Transclusion icon appears on the opposite side of the page in R...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-29
Assigned To: Moriel Schottlender
:
: 53161 (view as bug list)
Depends on:
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-07-07 21:35 UTC by Moriel Schottlender
Modified: 2013-08-29 00:01 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Moriel Schottlender 2013-07-07 21:35:28 UTC
Replication steps:

1. go here: https://he.wikipedia.org/wiki/%D7%A8%D7%97%D7%95%D7%91_%D7%99%D7%A8%D7%95%D7%A9%D7%9C%D7%99%D7%9D?veaction=edit

2. Click the box on the left (a 'street' template in the hebrew wiki)

3. The "Transclusion" icon appears on the right edge instead of the left. 

Happens in Chrome and Firefox 22.0 under Windows.

I suspect this is again a problem with the flipped position settings. I will take a look in the code.
Comment 1 matanya 2013-07-07 21:38:02 UTC
confirmed on Arch linux with FF 22.
Comment 2 Moriel Schottlender 2013-08-14 19:10:35 UTC
This may be an issue with the way the icon appears in general, not just specifically RTL. It seems the transclusion icon pops up on the side of the page, assuming the position is always on the side -- instead of, perhaps, appearing where the template box is located regardless of alignment.

I am not sure if this fix shouldn't be a deeper VE fix rather than the language-directionality specific fix.
Comment 3 James Forrester 2013-08-14 21:50:55 UTC
(In reply to comment #2)
> This may be an issue with the way the icon appears in general, not just
> specifically RTL. It seems the transclusion icon pops up on the side of the
> page, assuming the position is always on the side -- instead of, perhaps,
> appearing where the template box is located regardless of alignment.
> 
> I am not sure if this fix shouldn't be a deeper VE fix rather than the
> language-directionality specific fix.

Yes, I think a deeper fix might be appropriate - would you want to do that, or should I ask Rob?
Comment 4 Gerrit Notification Bot 2013-08-14 22:27:44 UTC
Change 79165 had a related patch set uploaded by Mooeypoo:
Fixing inspector popup position

https://gerrit.wikimedia.org/r/79165
Comment 5 Moriel Schottlender 2013-08-14 22:34:32 UTC
I posted a fix which seems to work but requires some testing and review. Also testing in RTL seems to work.
Comment 6 Amir E. Aharoni 2013-08-22 16:05:21 UTC
*** Bug 53161 has been marked as a duplicate of this bug. ***
Comment 7 Gerrit Notification Bot 2013-08-29 00:01:15 UTC
Change 79165 merged by jenkins-bot:
Fixing inspector popup position

https://gerrit.wikimedia.org/r/79165

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links