Last modified: 2014-01-14 22:17:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52906, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50906 - Blank lines are dropped from <pre>s by the serializer


Summary:	Blank lines are dropped from <pre>s by the serializer

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	ssastry

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-07 21:39 UTC by Derk-Jan Hartman
Modified:	2014-01-14 22:17 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-07-07 21:39:11 UTC

As can be seen here: https://en.wikipedia.org/w/index.php?title=User:Bevo&diff=prev&oldid=563114549

When you edit a <pre> block all blank lines are removed from the block.

Comment 1 Ed Sanders 2013-12-05 20:33:55 UTC

Appears parsoid is stripping extra linebreaks in <pre> tags. Maybe even a regression?

Comment 2 ssastry 2013-12-05 22:04:07 UTC

Verified that this bug is still around. This is not a selser issue, but a generic wikitext serialization issue.

[subbu@earth tests] echo "<pre>a\n\nb</pre>" | node parse --html2wt
 a
 
 b
[subbu@earth tests] echo "<pre>a\n\nb\n\nc</pre>" | node parse --html2wt
 a
 b
 c

Comment 3 ssastry 2013-12-05 23:01:47 UTC

Fix in https://gerrit.wikimedia.org/r/#/c/97165/

Comment 4 ssastry 2014-01-14 22:17:09 UTC

This has been merged and deployed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links