Last modified: 2014-02-21 18:40:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52954, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50954 - After adding documentation, "Add documentation" should be "Edit documentation"
After adding documentation, "Add documentation" should be "Edit documentation"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Pratik Lahoti
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-08 16:34 UTC by Siebrand Mazeland
Modified: 2014-02-21 18:40 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2013-07-08 16:34:48 UTC
To add documentation for a string that has no documentation yet, one can click "Add documentation" in the translation editor. Once that is done, and the documentation has been saved, the link still reads "Add documentation". It should be "Edit documentation".

Steps to reproduce:
1. Open a message in translation editor that has no docs yet.
2. Click "Add documentation"
3. Enter text
4. Save documentation

Observed:
I. Link to add or update documentation reads "Add documentation" while there is documentation now.

Expected:
II. After adding initial documentation, link to edit documentation should read "Edit documentation".

Easy?
Comment 1 roopak 2013-11-03 09:27:33 UTC
Where is exactly the Add documentation function defined?
Comment 2 Nemo 2014-02-20 18:32:36 UTC
(In reply to Siebrand Mazeland from comment #0)
> Easy?

Nikerabbit> BPositive: 50954 shouldn't be too hard
Comment 3 Pratik Lahoti 2014-02-20 18:41:28 UTC
(In reply to Nemo from comment #2)
> (In reply to Siebrand Mazeland from comment #0)
> > Easy?
> 
> Nikerabbit> BPositive: 50954 shouldn't be too hard

Yes, I will work on this. Thanks.
Comment 4 Gerrit Notification Bot 2014-02-21 05:53:55 UTC
Change 114696 had a related patch set uploaded by BPositive:
'Add Documentation' link now changes to 'Edit Documentation' on adding the Documentation

https://gerrit.wikimedia.org/r/114696
Comment 5 Gerrit Notification Bot 2014-02-21 15:17:44 UTC
Change 114745 had a related patch set uploaded by BPositive:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

https://gerrit.wikimedia.org/r/114745
Comment 6 Gerrit Notification Bot 2014-02-21 17:41:45 UTC
Change 114745 abandoned by Nikerabbit:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

Reason:
Integrated into parent.

https://gerrit.wikimedia.org/r/114745
Comment 7 Gerrit Notification Bot 2014-02-21 18:30:12 UTC
Change 114696 merged by jenkins-bot:
'Add documentation' link now changes to 'Edit documentation' as soon as qqq exists

https://gerrit.wikimedia.org/r/114696
Comment 8 Nemo 2014-02-21 18:40:50 UTC
Congrats for your first bug fix, I hope to see many more soon!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links