Last modified: 2014-05-15 07:12:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52955, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50955 - VisualEditor: Clearer message when cancelling out of active edit
VisualEditor: Clearer message when cancelling out of active edit
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-05-15
Assigned To: Alex Monk
:
: 51655 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-08 16:41 UTC by Maggie Dennis
Modified: 2014-05-15 07:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maggie Dennis 2013-07-08 16:41:50 UTC
An English Wikipedia user requests clarification of the "cancel" process, saying:

"If you open a page in the VisualEditor, make a few changes, and then decide to hit the "Cancel" button, you get a message that says "Are you sure you want to go back to view mode without saving first?". The options are "OK" and "Cancel", which aren't really proper answers to this yes/no question. As such, I'd like to request that instead the buttons be replaced with "Yes" and "No", which are clear responses to the question. -Thunderforge (talk) 21:36, 6 July 2013 (UTC)"
Comment 1 James Forrester 2013-07-11 05:18:15 UTC
Unfortunately we can't actually replace the "OK" and "Cancel" buttons' text - that's supplied by the browser as is unchangeable.

What we can do is tweak the message so it's clear what this does, perhaps. Any ideas what might work better?
Comment 2 Ignatzmice 2013-07-19 04:29:57 UTC
See bug 51655, which should probably be closed as a duplicate. (On enwiki I'd say "merge".)
Comment 3 James Forrester 2013-07-19 21:05:09 UTC
*** Bug 51655 has been marked as a duplicate of this bug. ***
Comment 4 James Forrester 2013-07-19 21:06:30 UTC
From bug 51655 comment 1:

| The confirmation dialog should have more descriptive buttons, such as
|   [Discard edits] [Continue editing]
| , or
|   [Leave editing mode] [Return to editing]
| , etc.
| 
| For this to happen, it needs to become a jQuery dialog.
| 
| In fact, VE shouldn't use native confirm() dialogs; the implementation in
| most browsers is crappy.
Comment 5 Ignatzmice 2013-08-08 15:43:59 UTC
A user suggests [Return to editor] [Exit without saving]. https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&diff=567692036
Comment 6 Gerrit Notification Bot 2014-04-29 17:52:50 UTC
Change 130394 had a related patch set uploaded by Alex Monk:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394
Comment 7 Gerrit Notification Bot 2014-05-07 21:26:38 UTC
Change 132113 had a related patch set uploaded by Alex Monk:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113
Comment 8 Gerrit Notification Bot 2014-05-08 22:14:27 UTC
Change 132316 had a related patch set uploaded by Alex Monk:
Add confirmation dialog messages to MW core

https://gerrit.wikimedia.org/r/132316
Comment 9 Gerrit Notification Bot 2014-05-08 22:27:19 UTC
Change 132318 had a related patch set uploaded by Alex Monk:
Register OOUI confirmation dialog with windowFactory

https://gerrit.wikimedia.org/r/132318
Comment 10 Gerrit Notification Bot 2014-05-14 17:08:08 UTC
Change 132113 merged by jenkins-bot:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113
Comment 11 Gerrit Notification Bot 2014-05-14 21:24:58 UTC
Change 132318 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132318
Comment 12 Gerrit Notification Bot 2014-05-14 21:35:45 UTC
Change 132316 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132316
Comment 13 Gerrit Notification Bot 2014-05-14 23:02:42 UTC
Change 130394 merged by jenkins-bot:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links