Last modified: 2014-02-28 23:51:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52956, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50956 - VisualEditor: Reduce padding in editnotice popup because some existing edit notices already have some margin
VisualEditor: Reduce padding in editnotice popup because some existing edit n...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-08 17:00 UTC by Maggie Dennis
Modified: 2014-02-28 23:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maggie Dennis 2013-07-08 17:00:05 UTC
An editor from pt.wikipedia writes:

[E]ditnotices seems strange inside the flyout because there's a weird padding inside the popup, without the padding the templates would look nicer (there´s already padding in most edinotices templates by default). Dianakc (talk) 23:56, 6 July 2013 (UTC)
Comment 1 James Forrester 2013-07-08 17:04:34 UTC
(In reply to comment #0)
> An editor from pt.wikipedia writes:
> 
> [E]ditnotices seems strange inside the flyout because there's a weird padding
> inside the popup, without the padding the templates would look nicer (there´s
> already padding in most edinotices templates by default). Dianakc (talk)
> 23:56,
> 6 July 2013 (UTC)

I'm not sure that it's a better solution to get editors to make edit notices in uneditable HTML boxes, rather than the padding be system-level. The padding is designed to take normal edit notices; if you make fancy ones that break, the onus is generally on you. :-)

Note that we're planning on having setting/editing/removing page-level edit notices built into VisualEditor in the next few months, which will make enwiki's solution available to all wikis.
Comment 2 Diana 2013-08-03 00:43:23 UTC
Hi James,

I don't know what mean you by normal edit notices :) A simple 100% div, with background color but without padding would look weird inside the flyout.
We are rethinking the editnotices design/content and right now they look somewhat awkward within this asymmetrical padding. If someone ever need a margin it can be done within the editnotices itself, but this mandatory padding limits the design a lot.
Comment 3 James Forrester 2013-09-22 10:33:31 UTC
(In reply to comment #2)
> Hi James,
> 
> I don't know what mean you by normal edit notices :) A simple 100% div, with
> background color but without padding would look weird inside the flyout.
> We are rethinking the editnotices design/content and right now they look
> somewhat awkward within this asymmetrical padding. If someone ever need a
> margin it can be done within the editnotices itself, but this mandatory
> padding
> limits the design a lot.

Normal edit notices are text only (or bold/italics/links). Adding any further styling, including <span>s, <div>s, images, etc. is likely to break in a variety of situations and isn't really intended behaviour for the tool.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links