Last modified: 2013-07-16 16:53:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52978, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50978 - VisualEditor: Display references rendered by {{#tag:ref}} in superscript
VisualEditor: Display references rendered by {{#tag:ref}} in superscript
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-07-18
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-08 20:53 UTC by Krinkle
Modified: 2013-07-16 16:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of odd rendering when using {{#tag:ref}} (23.78 KB, image/png)
2013-07-08 20:53 UTC, Krinkle
Details

Description Krinkle 2013-07-08 20:53:53 UTC
Created attachment 12791 [details]
Screenshot of odd rendering when using {{#tag:ref}}

https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet?veaction=edit

See attachment, [11] renders as span instead of as <sup> (like [10]) and as such isn'y styled correctly (text is too big).
Comment 1 John Mark Vandenberg 2013-07-15 01:06:49 UTC
This is confusing because the lack of superscript makes these refs look like an external link.

This happens with all pages that use [[Template:Geographic reference]], which the English template page says is "a very large number of Wikipedia articles", and that template exists in 15 other Wikipedias including a few on the 'maybe' list for 22 July deployment.

Example in the wild:

https://en.wikipedia.org/wiki/Branford,_Florida?veaction=edit
Comment 2 Roan Kattouw 2013-07-15 01:13:05 UTC
Parsoid incorrectly renders references as <span>s. The ones directly in the main documented are rendered as <sup>s by VE, but we don't control the ones in templates and other generated content (and #tag is a ParserFunction).
Comment 3 Roan Kattouw 2013-07-15 01:15:25 UTC
(In reply to comment #2)
> Parsoid incorrectly renders references as <span>s. The ones directly in the
> main documented are rendered as <sup>s by VE, but we don't control the ones
> in
> templates and other generated content (and #tag is a ParserFunction).
Ugh, didn't see James's summary edit. Moving back to VE.

We could probably add CSS to make <span class="reference"> render as a superscript, or munge it in some other way. Though ideally I'd like us to convince Parsoid to render references as <sup>s the way the PHP parser does.
Comment 4 Gerrit Notification Bot 2013-07-16 16:20:05 UTC
Change 73980 had a related patch set uploaded by Esanders:
Fake superscript style for references generated as spans

https://gerrit.wikimedia.org/r/73980
Comment 5 Gerrit Notification Bot 2013-07-16 16:42:46 UTC
Change 73980 merged by jenkins-bot:
Fake superscript style for references generated as spans

https://gerrit.wikimedia.org/r/73980
Comment 6 James Forrester 2013-07-16 16:53:41 UTC
Fixed and will go out later today.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links