Last modified: 2013-07-09 04:26:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52990, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50990 - html2html tests: better normalization
html2html tests: better normalization
Status: RESOLVED WONTFIX
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-08 23:07 UTC by ssastry
Modified: 2013-07-09 04:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-07-08 23:07:01 UTC 
html2html mode should normalize insignificant whitespace in elements before comparing output (ex: list items) to prevent artificial test failures.
Comment 1 Gabriel Wicke 2013-07-09 00:43:22 UTC 
For list items we should also be able to match the PHP parser's behavior of consuming optional whitespace after a bullet. This should also avoid the test failures introduced in https://gerrit.wikimedia.org/r/#/c/72112/.

I doubt that doing so is overly complicated. If it is about the same amount of work / complexity as encoding the differences with normalization and specialized tests then I'm strongly leaning towards simply fixing it.
Comment 2 Gabriel Wicke 2013-07-09 00:48:41 UTC 
More detail on list items: bug 50771
Comment 3 Gabriel Wicke 2013-07-09 03:36:40 UTC 
Alternative approach favored by Roan and me: bug 51004
Comment 4 ssastry 2013-07-09 04:26:01 UTC 
I'll close this ticket then since we dont need both.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links