Last modified: 2014-03-20 21:22:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52998, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50998 - VisualEditor: "Apply changes" label should be replaced with "Insert template/reflist" when inserting template/reflist
VisualEditor: "Apply changes" label should be replaced with "Insert template/...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-03-13
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 02:29 UTC by Erik Moeller
Modified: 2014-03-20 21:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Moeller 2013-07-09 02:29:58 UTC
When inserting a new template, the template dialog button label "Apply changes" doesn't make sense, since we're not changing an existing element. In that case, the button should be labeled "Insert template".

Similarly, when inserting the list of references, the button should be labeled "Insert references list", not "Apply changes".

In contrast, when inserting a footnote or media file, the button is correctly labeled "Insert reference" or "Insert media".
Comment 1 Gerrit Notification Bot 2014-03-10 00:54:18 UTC
Change 117342 had a related patch set uploaded by Jforrester:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342
Comment 2 Gerrit Notification Bot 2014-03-12 23:21:30 UTC
Change 117342 merged by jenkins-bot:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342
Comment 3 Rummana Yasmeen 2014-03-15 00:40:08 UTC
Verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&veaction=edit
Comment 4 Rummana Yasmeen 2014-03-20 21:22:01 UTC
Verified the fix production:https://en.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox?veaction=edit

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links