Last modified: 2014-03-04 16:52:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53003, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51003 - Strip leading / trailing whitespace out of transclusion parameters, and try to match single / multi-line style
Strip leading / trailing whitespace out of transclusion parameters, and try t...
Status: NEW
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
: 51175 (view as bug list)
Depends on: 62217
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 03:09 UTC by Gabriel Wicke
Modified: 2014-03-04 16:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-07-09 03:09:37 UTC
We currently include newlines in transclusion parameters, which lets users delete them. That can create diffs like this: https://en.wikipedia.org/w/index.php?title=2013_Campbell%27s_Hall_of_Fame_Tennis_Championships_%E2%80%93_Singles&curid=39873236&diff=563465891&oldid=563456914

Instead we should strip whitespace from transclusion parameters and manage newlines and the whitespace between equal and value transparently in Parsoid.

This also means that we should try to

* match single / multi-line style with other transclusion parameters
* create new transclusions with single or multi-line style either based on 
** a heuristic like the number of parameters or total chars, or 
** based on convention information from TemplateData or the like
Comment 1 Gerrit Notification Bot 2013-07-09 23:18:34 UTC
Change 72864 had a related patch set uploaded by GWicke:
Bug 51003: Template parameter handling cleanup

https://gerrit.wikimedia.org/r/72864
Comment 2 Gerrit Notification Bot 2013-07-10 00:35:02 UTC
Change 72864 merged by jenkins-bot:
Bug 51003: Template parameter handling cleanup

https://gerrit.wikimedia.org/r/72864
Comment 3 Gabriel Wicke 2013-07-10 00:39:23 UTC
This patch cleans up whitespace handling in parameters a bit.

Matching the existing style of a template (or the style convention for a template) is still left to do.
Comment 4 Gabriel Wicke 2013-07-19 22:01:00 UTC
*** Bug 51175 has been marked as a duplicate of this bug. ***
Comment 5 Gabriel Wicke 2013-07-19 22:13:38 UTC
We should probably strip newlines in empty parameter values separately:
https://en.wikipedia.org/w/index.php?title=2013%E2%80%9314_Liga_I&curid=36025002&diff=564981513&oldid=564979200

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links