Last modified: 2014-07-15 09:00:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53012, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51012 - VisualEditor: Make defaultsort input field wider
VisualEditor: Make defaultsort input field wider
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-03-20
Assigned To: mvolz
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-09 07:34 UTC by This, that and the other (TTO)
Modified: 2014-07-15 09:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of 30em width in default sort field (121.15 KB, image/png)
2014-03-16 22:14 UTC, mvolz
Details
Screenshot of 100% width in default sort field (122.42 KB, image/png)
2014-03-16 22:15 UTC, mvolz
Details
Other dialogs affected by change (285.55 KB, image/png)
2014-03-16 22:33 UTC, mvolz
Details

Description This, that and the other (TTO) 2013-07-09 07:34:04 UTC
To fit long page titles. 

There's plenty of empty space in the dialog box that could be put to use.
Comment 1 mvolz 2014-03-16 22:14:44 UTC
Created attachment 14832 [details]
Screenshot of 30em width in default sort field

So I've looked into this a bit and took some screenshots.

Currently this is set in the class .oo-ui-textInputWidget and is set to 20em. The text input widget appears in Options -> Categories, Options -> Page Settings, and Insert -> Reference. 

These 3 fields all look acceptable at a width of 30em. We could also go for 100% width of the div. I like the look of this in the two Options areas, although this looks a bit odd in the Reference dialog "group by" field. I think that even 20em was too wide for it to begin with- maybe we should add a special class here?

Any opinions? I like both 30 em and 100%, and since reference dialog is likely to undergo radical UI changes the size of the group by field in the reference dialog could be ignored for the time being.
Comment 2 mvolz 2014-03-16 22:15:55 UTC
Created attachment 14833 [details]
Screenshot of 100% width in default sort field
Comment 3 mvolz 2014-03-16 22:33:40 UTC
Created attachment 14834 [details]
Other dialogs affected by change
Comment 4 Gerrit Notification Bot 2014-03-17 18:52:00 UTC
Change 119092 had a related patch set uploaded by Mvolz:
Increases width of defaultsort and page redirect fields in options dialog

https://gerrit.wikimedia.org/r/119092
Comment 5 Gerrit Notification Bot 2014-03-17 18:58:29 UTC
Change 119092 merged by jenkins-bot:
Increases width of defaultsort and page redirect fields in options dialog

https://gerrit.wikimedia.org/r/119092
Comment 6 James Forrester 2014-03-17 19:03:56 UTC
Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links