Last modified: 2013-08-21 22:35:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53062, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51062 - JSON validator still allows properties that aren't in the schema if they're inside the sections array
JSON validator still allows properties that aren't in the schema if they're i...
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
BookManagerv2 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Molly White
:
Depends on:
Blocks: 50958
  Show dependency tree / graph
 
Reported: 2013-07-09 19:16 UTC by Molly White
Modified: 2013-08-21 22:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Molly White 2013-07-09 19:16:16 UTC 
It appears that maybe the JSON validation doesn't recurse into the child nodes of the sections property.
Comment 1 Yuvi Panda 2013-07-09 19:49:09 UTC 
You should poke Ori-l about this, IIRC it was an intentional design decision (assuming you're using JsonSchema.php)
Comment 2 Yuvi Panda 2013-07-09 21:35:19 UTC 
(It's also something I'd like for UW :) )
Comment 3 Gerrit Notification Bot 2013-08-21 22:34:33 UTC 
Change 80308 had a related patch set uploaded by Mollywhite:
Bug 51062: Update schema so additional properties aren't allowed.

https://gerrit.wikimedia.org/r/80308
Comment 4 Gerrit Notification Bot 2013-08-21 22:34:56 UTC 
Change 80308 merged by Mollywhite:
Bug 51062: Update schema so additional properties aren't allowed.

https://gerrit.wikimedia.org/r/80308
Comment 5 Molly White 2013-08-21 22:35:47 UTC 
It turns out that this was happening because I needed

"additionalProperties": false

_within_ the sections array of the schema.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links