Last modified: 2013-07-30 22:02:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53066, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 51066 - VisualEditor: Link input field identifiers in DOM are bogus


Summary:	VisualEditor: Link input field identifiers in DOM are bogus

Status:	RESOLVED INVALID

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Rob Moen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-09 19:38 UTC by Chris McMahon
Modified:	2013-07-30 22:02 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
corrupt <class> identifier in DOM for Link (64.42 KB, image/png) 2013-07-09 19:38 UTC, Chris McMahon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Chris McMahon 2013-07-09 19:38:59 UTC

Created attachment 12807 [details]
corrupt <class> identifier in DOM for Link

see screenshot

what is this "class"?

Comment 1 Trevor Parscal 2013-07-30 22:02:49 UTC

It's not corrupt, it's just empty.

jQuery doesn't remove the attribute when removing the last class. In this case, we add the class to make the input "pending" and then remove it when the AJAX call is done.

I don't think this is a real problem - if you have code that takes a different path based on whether the class attribute is set, has a non-empty value, or has a value, I suspect the first two cases should just be folded together.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links