Last modified: 2013-07-10 05:13:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53079, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51079 - Pages outside of NS_MAIN are returned
Pages outside of NS_MAIN are returned
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-09 23:47 UTC by Matthew Flaschen
Modified: 2013-07-10 05:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-07-09 23:47:33 UTC 
Only articles (NS_MAIN pages) are supposed to be returned, but this is no longer enforced.
Comment 1 Steven Walling 2013-07-09 23:53:18 UTC 
Confirmed, you can see this if you look for the recentchanges tag and other namespaces. Like: https://en.wikipedia.org/w/index.php?title=User:Dita823/DalesBus&action=history

This is obviously rare, but we should add an explicit main NS check.
Comment 2 Gerrit Notification Bot 2013-07-10 00:05:09 UTC 
Change 72872 had a related patch set uploaded by Mattflaschen:
Check namespace in isAppropriateArticle.

https://gerrit.wikimedia.org/r/72872
Comment 3 Gerrit Notification Bot 2013-07-10 00:12:09 UTC 
Change 72872 merged by jenkins-bot:
Check namespace in isAllowedArticle.

https://gerrit.wikimedia.org/r/72872
Comment 4 Steven Walling 2013-07-10 05:13:52 UTC 
The previously linked patch was tested, verified on labs, and merged. 

Thanks for the quick fix Matt!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links