Last modified: 2014-01-30 04:56:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53087, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51087 - Parsoid doesn't serialize <p>s in <blockquote>s correctly
Parsoid doesn't serialize <p>s in <blockquote>s correctly
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-10 01:13 UTC by Roan Kattouw
Modified: 2014-01-30 04:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-07-10 01:13:27 UTC 
Input HTML:
<blockquote>Foo<p>Bar</p></blockquote>

Output wikitext from serializer:
<blockquote>Foo
Bar</blockquote>

This is incorrect because:
* You need 2 newlines to create a new paragraph, not one
* Two newlines don't create a paragraph inside a blockquote per bug 51086
Comment 1 C. Scott Ananian 2013-08-12 18:44:13 UTC 
Two newlines do create a paragraph inside a blockquote now (bug 6200 was fixed in the PHP parser).  But parsoid's output is still incorrect (only has a single newline).
Comment 2 ssastry 2013-09-04 17:38:15 UTC 
This is actually unrelated to blockquote and is a more generic problem of children of block-nodes. Patch coming in a bit.
Comment 3 ssastry 2013-09-04 17:47:39 UTC 
https://gerrit.wikimedia.org/r/#/c/82639/
Comment 4 Arlo Breault 2014-01-30 04:56:57 UTC 
This looks fixed.

echo "<blockquote>Foo<p>Bar</p></blockquote>" | node parse --html2wt
<blockquote>Foo
Bar
</blockquote>
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links