Last modified: 2013-07-18 22:45:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53099, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51099 - Client fails with fatal error: Argument 1 passed to Wikibase\TermSqlIndex::__construct() must be an instance of Wikibase\StringNormalizer, string given
Client fails with fatal error: Argument 1 passed to Wikibase\TermSqlIndex::_...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Immediate blocker (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-10 08:54 UTC by Daniel Kinzler
Modified: 2013-07-18 22:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2013-07-10 08:54:06 UTC
The client fails with a fatal error (at least) when rendering a page that uses item labels or accesses properties by label:

Catchable fatal error: Argument 1 passed to  Wikibase\TermSqlIndex::__construct() must be an instance of  Wikibase\StringNormalizer, string given

This is caused by a change in TermSqlIndex's constructor and my failure to update DirectSqlStore accordingly.
Comment 1 Daniel Kinzler 2013-07-10 08:55:23 UTC
https://gerrit.wikimedia.org/r/#/c/72835/
Comment 2 Gerrit Notification Bot 2013-07-10 08:55:46 UTC
Change 72835 had a related patch set uploaded by Daniel Kinzler:
Fix construction of TermSqlIndex in client.

https://gerrit.wikimedia.org/r/72835
Comment 3 Gerrit Notification Bot 2013-07-10 08:56:02 UTC
Change 72843 had a related patch set uploaded by Daniel Kinzler:
Adding tests for DirectSqlStore

https://gerrit.wikimedia.org/r/72843
Comment 4 Gerrit Notification Bot 2013-07-10 09:24:14 UTC
Change 72835 merged by Jeroen De Dauw:
(bug 51099) Fix construction of TermSqlIndex in client.

https://gerrit.wikimedia.org/r/72835
Comment 5 Gerrit Notification Bot 2013-07-10 09:25:57 UTC
Change 72843 merged by Jeroen De Dauw:
(bug 51099) Adding tests for DirectSqlStore

https://gerrit.wikimedia.org/r/72843
Comment 6 abraham.taherivand 2013-07-17 14:31:35 UTC
Verified in Wikidata demo time July 17th
Comment 7 Gerrit Notification Bot 2013-07-18 22:37:52 UTC
Change 74544 had a related patch set uploaded by Aude:
(bug 51099) Fix construction of TermSqlIndex in client.

https://gerrit.wikimedia.org/r/74544
Comment 8 Gerrit Notification Bot 2013-07-18 22:45:48 UTC
Change 74544 abandoned by Aude:
(bug 51099) Fix construction of TermSqlIndex in client.

Reason:
not the same issue

https://gerrit.wikimedia.org/r/74544

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links