Last modified: 2013-07-12 05:30:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53100, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51100 - Parsoid unable to parse news:// like URLs
Parsoid unable to parse news:// like URLs
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal trivial
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-10 09:03 UTC by Kelson [Emmanuel Engelhart]
Modified: 2013-07-12 05:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kelson [Emmanuel Engelhart] 2013-07-10 09:03:20 UTC 
Following wiki code:
[news://comp.lang.apl my_newsgroup]

... should generates something like:
<a rel="nofollow" class="external text" href="news://comp.lang.apl">my_newsgroup</a>

... but generates:
<a rel="mw:ExtLink" data-parsoid='{"targetOff":22,"a":{"href":null},"sa":{"href":"news://comp.lang.apl"},"dsr":[0,35,22,1]}'>my_newsgroup</a>

so, without "href" attribute to the "a" node.
Comment 1 Gabriel Wicke 2013-07-12 01:08:45 UTC 
This is a bug in our Sanitizer. sanitizeHref uses a constant list of URL protocols rather than the list of allowed protocols from WikiConfig.
Comment 2 Gerrit Notification Bot 2013-07-12 01:11:07 UTC 
Change 73374 had a related patch set uploaded by GWicke:
Bug 51100: Use wiki-specific protocol regexp in sanitizer

https://gerrit.wikimedia.org/r/73374
Comment 3 Gerrit Notification Bot 2013-07-12 03:59:25 UTC 
Change 73374 merged by jenkins-bot:
Bug 51100: Use wiki-specific protocol regexp in sanitizer

https://gerrit.wikimedia.org/r/73374
Comment 4 Gabriel Wicke 2013-07-12 05:30:08 UTC 
Should be deployed tomorrow.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links