Last modified: 2013-07-19 12:10:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53101, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51101 - Checkmark icon for IME repeated behind menu
Checkmark icon for IME repeated behind menu
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Santhosh Thottingal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-10 09:13 UTC by Michael M.
Modified: 2013-07-19 12:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (FF10, Wikidata) (13.57 KB, image/png)
2013-07-10 09:13 UTC, Michael M.
Details

Description Michael M. 2013-07-10 09:13:45 UTC
Created attachment 12814 [details]
Screenshot (FF10, Wikidata)

In FF10 (no, I can't update) and IE9 in quirks mode the checkmark icon is repeated in both directions behind the menu.
Comment 1 Siebrand Mazeland 2013-07-10 16:46:18 UTC
Also observed on for example iOS/iPad.
Comment 2 Michael M. 2013-07-19 09:30:27 UTC
In https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/4e75a366efc79aed81a9d5e9f75b7c0de2ec4e30/lib%2Fjquery.ime%2Fcss%2Fjquery.ime.css#L171

the no-repeat is last in the decleration, while the "normal" position is directly after the url. Probably the broken browsers expect the different parts in the normal order and don't interprete them correctly otherwise.
Comment 3 Siebrand Mazeland 2013-07-19 09:56:57 UTC
For convenience pasting all uses of no-repeat in ULS. Sorted the occurrences in two groups.

no-repeat immediately after URL:

lib/jquery.ime/css/jquery.ime.css:      background: url('../images/ime-active.png') no-repeat left center;
lib/jquery.uls/css/jquery.uls.css:      background: transparent url('../images/icon-language.png') no-repeat scroll left center;
lib/jquery.uls/css/jquery.uls.css:      background: transparent url('../images/world_map.png') no-repeat scroll right top;
lib/jquery.uls/css/jquery.uls.css:      background: transparent url('../images/close.png') no-repeat scroll center center;
lib/jquery.uls/css/jquery.uls.css:      background: transparent url('../images/search.png') no-repeat scroll right center;
lib/jquery.uls/css/jquery.uls.css:      background: transparent url('../images/clear.png') no-repeat scroll left center;

no-repeat not immediately after URL:

lib/jquery.ime/css/jquery.ime.css:      background: url(../images/tick.png) left 4px center no-repeat;
resources/css/ext.uls.displaysettings.css:      background: transparent url('../images/display.png') left top no-repeat;
resources/css/ext.uls.css:      background: transparent url('../images/cog-sprite.png') right top no-repeat;
resources/css/ext.uls.css:      background: transparent url('../images/help.png') left center no-repeat;
resources/css/ext.uls.inputsettings.css:        background: transparent url('../images/input.png') left top no-repeat;
resources/css/ext.uls.inputsettings.css:        background: transparent url('../images/remove-input.png') left top no-repeat;
resources/css/ext.uls.inputsettings.css:        background: transparent url('../images/cog.png') center top no-repeat;

Michael, are you familiar with any upstream reports on certain browsers or rendering engines behaving badly depending on where no-repeat is positioned? I'm not able to find a specification anywhere so far that seems to demand that the properties are specified in a certain order.
Comment 4 Michael M. 2013-07-19 10:33:59 UTC
(In reply to comment #3)
> I'm not able to find a specification anywhere so far that seems to demand
> that
> the properties are specified in a certain order.

There is no such specification: http://www.w3.org/TR/css3-background/#the-background uses || as separator in the syntax, which means "at least one in any order" (http://www.w3.org/TR/WD-css3-syntax-20030813/#property-def-value), so it should work in any order. All current browsers seem to interprete the background syntax correctly in any order.

But in FF10 I can see in the CSS inspector that the background is set to only

-moz-linear-gradient(transparent, transparent), url("//bits.wikimedia.org/static-1.22wmf10/extensions/UniversalLanguageSelector/lib/jquery.ime/css/../images/tick.svg?2013-07-11T14:26:40Z")

so probably this issue can be fixed by moving the no-repeat to directly after the url.
Comment 5 Gerrit Notification Bot 2013-07-19 10:43:18 UTC
Change 74602 had a related patch set uploaded by Siebrand:
Have no-repeat follow url for background images

https://gerrit.wikimedia.org/r/74602
Comment 6 Siebrand Mazeland 2013-07-19 10:49:44 UTC
Upstream pull request, complementary to the one in comment 5 that only addresses non-lib code, at https://github.com/wikimedia/jquery.ime/pull/221.
Comment 7 Santhosh Thottingal 2013-07-19 11:32:46 UTC
background shorthand property should have this order as per http://www.w3schools.com/css/css_background.asp

background-color
background-image
background-repeat
background-attachment
background-position
Comment 8 Gerrit Notification Bot 2013-07-19 11:53:47 UTC
Change 74602 merged by jenkins-bot:
Have no-repeat follow url for background images

https://gerrit.wikimedia.org/r/74602

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links