Last modified: 2014-10-07 21:49:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53141, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51141 - VisualEditor: Nicer removal of Cite.php's class=error
VisualEditor: Nicer removal of Cite.php's class=error
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-10 23:05 UTC by James Forrester
Modified: 2014-10-07 21:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-07-10 23:05:01 UTC
Currently this is really ugly; Trevor's better class will help, but in general we want to do this better.
Comment 1 Alex Monk 2014-07-24 21:42:21 UTC
So what is this about? There's a lot of missing context here.
Comment 2 Alex Monk 2014-09-07 21:23:47 UTC
Hello?
Comment 3 James Forrester 2014-09-08 22:44:30 UTC
Sorry!

This refers to the hacky fix for bug 50423 which added (eventually):

  /* HACK: Hide Ref errors in templates */
  .mw-ext-cite-error {
	display: none;
  }

… to ve.ce.MWReferenceNode.css

This bug is asking for a way for these errors to not be shown that doesn't just suppress the conent (they're caused by the templates rendering out of context).
Comment 4 Alex Monk 2014-09-15 23:40:03 UTC
(In reply to James Forrester from comment #3)
> Sorry!
> 
> This refers to the hacky fix for bug 50423 which added (eventually):
> 
>   /* HACK: Hide Ref errors in templates */
>   .mw-ext-cite-error {
> 	display: none;
>   }
> 
> … to ve.ce.MWReferenceNode.css
> 
> This bug is asking for a way for these errors to not be shown that doesn't
> just suppress the conent (they're caused by the templates rendering out of
> context).

I guess we could send some 'nocontext' parameter in the HTTP request which would suppress errors based on missing information... Sounds like it would be even worse than the current solution though.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links