Last modified: 2013-08-29 09:01:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53173, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51173 - <nowiki/> added to wikilinks
<nowiki/> added to wikilinks
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-11 14:43 UTC by Maggie Dennis
Modified: 2013-08-29 09:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maggie Dennis 2013-07-11 14:43:52 UTC
In http://en.wikipedia.org/w/index.php?title=Renewable_energy_in_Seychelles&diff=prev&oldid=563530801, the contributor says that he selected the words "diesel generators" for linking, but the editor inserted the nowiki to prevent the plural being part of the display. 

See http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=563816729#Changing_link_text_often_results_in_bad_code.2C_wrong_links_and_unmatched_.3C.2Fnowki.3Es for this and other cases. I'm afraid i'm not quite sure how to report this, since I'm not sure what's happening.
Comment 1 James Forrester 2013-07-11 18:28:29 UTC
If the user selects "diesel generator" (i.e., misses the 's'), the resultant HTML would be

  <a href=foo>diesel generator</a>s 

The correct wikitext version of this is indeed

  [[diesel generator]]<nowiki />s

… which is probably not what the user wanted to do, but it appears to be what they asked VisualEditor to do.

Consequently, I'm going to mark this as INVALID [If this is not the case - that the user did indeed select the entirety of the two words and there's a bug, I'd really love to know what browser they were using so we can hunt down the problem in our selection code!]

Had they instead selected "diesel generators", VisualEditor/Parsoid would have created this as:

  [[diesel generator|diesel generators]]

… which is not ideal (I'd prefer the shorter [[diesel generator]]s) but does the job. (I've just triple-checked this in Firefox, Chrome and Safari - it doesn't appear to have broken.)

We could always expand users' selections to what we think they should have selected, but this would make it impossible for users to do some things that they may want to do, albeit less frequently. I'm not sure that preventing users from doing things that they can do in wikitext would be a good solution, in general.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links