Last modified: 2014-07-02 20:12:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53174, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51174 - Scap broken for deploying new versions of MediaWiki due to ExtensionMessage file not being created
Scap broken for deploying new versions of MediaWiki due to ExtensionMessage f...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: High major (vote)
: ---
Assigned To: Bryan Davis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-11 15:00 UTC by Sam Reed (reedy)
Modified: 2014-07-02 20:12 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-07-11 15:00:01 UTC
Looks like this is related to the improvements Ori and Tim made after the last issues.

When deploying a new version, wmf-config/ExtensionMessages-1.XXwmfY.php isn't created so it can be used

reedy@tin:/a/common$ scap test2wiki to 1.22wmf10 and rebuild l10n cache
Checking syntax... done
Copying to tin from tin.eqiad.wmnet...ok
Done
Updating ExtensionMessages-1.22wmf9.php...
done
Updating LocalisationCache for 1.22wmf9... done
Updating ExtensionMessages-1.22wmf8.php...
done
Updating LocalisationCache for 1.22wmf8... done
Updating ExtensionMessages-1.22wmf10.php...PHP Warning:  require(/a/common/php-1.22wmf10/../wmf-config/ExtensionMessages-1.22wmf10.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2632

Warning: require(/a/common/php-1.22wmf10/../wmf-config/ExtensionMessages-1.22wmf10.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2632
PHP Fatal error:  require(): Failed opening required '/a/common/php-1.22wmf10/../wmf-config/ExtensionMessages-1.22wmf10.php' (include_path='/a/common/php-1.22wmf10/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.22wmf10:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2632

Fatal error: require(): Failed opening required '/a/common/php-1.22wmf10/../wmf-config/ExtensionMessages-1.22wmf10.php' (include_path='/a/common/php-1.22wmf10/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.22wmf10:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2632
Update of MediaWiki localisation messages failed
sync failed
reedy@tin:/a/common$


Worked around in the laziest way possible - copied the wmf9 file to wmf10


reedy@tin:/a/common$ scap test2wiki to 1.22wmf10 and rebuild l10n cache
Checking syntax... done
Copying to tin from tin.eqiad.wmnet...ok
Done
Updating ExtensionMessages-1.22wmf9.php...
done
Updating LocalisationCache for 1.22wmf9... done
Updating ExtensionMessages-1.22wmf8.php...
done
Updating LocalisationCache for 1.22wmf8... done
Updating ExtensionMessages-1.22wmf10.php...
done
Updating LocalisationCache for 1.22wmf10... done
Comment 1 Sam Reed (reedy) 2013-07-18 17:07:04 UTC
Seems ok this week.. :/
Comment 2 Ori Livneh 2013-07-18 17:09:07 UTC
(In reply to comment #1)
> Seems ok this week.. :/

What was different? Were any new extensions deployed?
Comment 3 Sam Reed (reedy) 2013-07-18 17:12:40 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Seems ok this week.. :/
> 
> What was different? Were any new extensions deployed?

Nothing I don't think. It should create a ExtensionMessages-1.22wmfXX.php each time
Comment 4 Andre Klapper 2013-07-22 15:48:57 UTC
Would be great to update this after today's deployment, either as WORKSFORME or as still valid.
Comment 5 Sam Reed (reedy) 2013-07-22 18:47:34 UTC
(In reply to comment #4)
> Would be great to update this after today's deployment, either as WORKSFORME
> or
> as still valid.

We're not deploying a new version, scap won't be used today
Comment 6 Andre Klapper 2013-08-13 13:08:42 UTC
So what's the state of this, a few weeks later?
Comment 7 Sam Reed (reedy) 2013-11-14 19:32:15 UTC
This seems to have come back again:


reedy@tin:/a/common$ scap testwiki to 1.23wmf4 and build l10n cache
Checking syntax... done
Copying to tin from tin.eqiad.wmnet...ok
Done
Updating ExtensionMessages-1.23wmf3.php...
done
Copying to local copy...
done
Updating LocalisationCache for 1.23wmf3... done
Updating ExtensionMessages-1.23wmf2.php...
done
Copying to local copy...
done
Updating LocalisationCache for 1.23wmf2... done
Updating ExtensionMessages-1.23wmf4.php...PHP Warning:  require(/a/common/php-1.23wmf4/../wmf-config/ExtensionMessages-1.23wmf4.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2636

Warning: require(/a/common/php-1.23wmf4/../wmf-config/ExtensionMessages-1.23wmf4.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2636
PHP Fatal error:  require(): Failed opening required '/a/common/php-1.23wmf4/../wmf-config/ExtensionMessages-1.23wmf4.php' (include_path='/a/common/php-1.23wmf4/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf4:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2636

Fatal error: require(): Failed opening required '/a/common/php-1.23wmf4/../wmf-config/ExtensionMessages-1.23wmf4.php' (include_path='/a/common/php-1.23wmf4/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf4:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2636
Update of MediaWiki localisation messages failed
sync failed
reedy@tin:/a/common$ ./multiversion/activeMWVersions
1.23wmf3 1.23wmf2 1.23wmf4
reedy@tin:/a/common$
Comment 8 Greg Grossmeier 2013-11-18 20:56:52 UTC
Reopened, still highest/major?
Comment 9 Sam Reed (reedy) 2013-11-18 21:21:44 UTC
Not exactly, it's easily "worked around" (make a copy of the previous versions file) I just don't get why it works fine for a few weeks, and then it doesn't. Which is annoying
Comment 10 Sam Reed (reedy) 2014-02-06 16:07:24 UTC
Not seen this for a few weeks... Seems to have come back again today


reedy@tin:/a/common$ scap testwiki to 1.23wmf13 and build l10n cache
[2014-02-06 16:04:31,041] started scap: testwiki to 1.23wmf13 and build l10n cache
[2014-02-06 16:04:31,056] Checking syntax
Copying to tin from tin.eqiad.wmnet...ok
Done
Updating ExtensionMessages-1.23wmf12.php...
done
Copying to local copy...
done
Updating LocalisationCache for 1.23wmf12... done
Updating ExtensionMessages-1.23wmf11.php...
done
Copying to local copy...
done
Updating LocalisationCache for 1.23wmf11... done
Updating ExtensionMessages-1.23wmf13.php...PHP Warning:  require(/a/common/php-1.23wmf13/../wmf-config/ExtensionMessages-1.23wmf13.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2660

Warning: require(/a/common/php-1.23wmf13/../wmf-config/ExtensionMessages-1.23wmf13.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2660
PHP Fatal error:  require(): Failed opening required '/a/common/php-1.23wmf13/../wmf-config/ExtensionMessages-1.23wmf13.php' (include_path='/a/common/php-1.23wmf13/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf13:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2660

Fatal error: require(): Failed opening required '/a/common/php-1.23wmf13/../wmf-config/ExtensionMessages-1.23wmf13.php' (include_path='/a/common/php-1.23wmf13/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf13:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2660
Update of MediaWiki localisation messages failed
Traceback (most recent call last):
  File "/usr/local/bin/scap", line 220, in <module>
    scap()
  File "/usr/local/bin/scap", line 177, in scap
    subprocess.check_call('/usr/local/bin/mw-update-l10n')
  File "/usr/lib/python2.7/subprocess.py", line 511, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/usr/local/bin/mw-update-l10n' returned non-zero exit status 1
Comment 11 Sam Reed (reedy) 2014-02-13 18:16:27 UTC
Updating ExtensionMessages-1.23wmf14.php...PHP Warning:  require(/a/common/php-1.23wmf14/../wmf-config/ExtensionMessages-1.23wmf14.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2673

Warning: require(/a/common/php-1.23wmf14/../wmf-config/ExtensionMessages-1.23wmf14.php): failed to open stream: No such file or directory in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2673
PHP Fatal error:  require(): Failed opening required '/a/common/php-1.23wmf14/../wmf-config/ExtensionMessages-1.23wmf14.php' (include_path='/a/common/php-1.23wmf14/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf14:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2673

Fatal error: require(): Failed opening required '/a/common/php-1.23wmf14/../wmf-config/ExtensionMessages-1.23wmf14.php' (include_path='/a/common/php-1.23wmf14/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.23wmf14:/usr/local/lib/php:/usr/share/php') in /usr/local/apache/common-local/wmf-config/CommonSettings.php on line 2673
Update of MediaWiki localisation messages failed
18:09:25 ERROR - scap failed: CalledProcessError Command '/usr/local/bin/mw-update-l10n' returned non-zero exit status 1 (duration: 03m 04s)
Comment 12 Gerrit Notification Bot 2014-02-13 21:43:18 UTC
Change 113260 had a related patch set uploaded by BryanDavis:
Touch ExtensionMessages-VERSION if not present

https://gerrit.wikimedia.org/r/113260
Comment 13 Gerrit Notification Bot 2014-02-19 21:21:33 UTC
Change 113260 merged by Ori.livneh:
Add bootstrap initialization for l10n update in new branches

https://gerrit.wikimedia.org/r/113260
Comment 14 Bryan Davis 2014-02-20 00:53:15 UTC
Tested fix on tin by renaming ExtensionMessages-1.23wmf14.php to ExtensionMessages-1.23wmf14.php-bak and running mw-update-l10n. ExtensionMessages-1.23wmf14.php was recreated with no diff from backup (and no crash).
Comment 15 Bryan Davis 2014-02-21 23:03:56 UTC
The patch seemed to work for the wmf15 rollout, but due to other issues we should probably wait to see what happens with wmf16 before we mark this as resolved.
Comment 16 Bryan Davis 2014-02-27 20:24:39 UTC
During wmf16 deploy we noticed missing en translations on www.mediawiki.org. 

Running a full scap for just wmf16 branch (scap --versions php-1.23wmf16 'rebuild php-1.23wmf16 l10n cache') failed with:

  Warning: opendir(/upstream): failed to open dir: No such file or directory in /srv/scap/bin/mergeCdbFileUpdates on line 76
  Could not open directory '/upstream'.

This looks to be a bug in the scap-rebuild-cdbs call when versions are specified manually.

Rerunning as a full scap (scap 'full scap; rebuild php-1.23wmf16 l10n cache') performed the scap-rebuild-cdbs step correctly. It also seemed to fix the l10n cache on mw.o.
Comment 17 Gerrit Notification Bot 2014-03-06 03:03:20 UTC
Change 117154 had a related patch set uploaded by BryanDavis:
Delete stub l10n file after generating ExtensionMessages

https://gerrit.wikimedia.org/r/117154
Comment 18 Gerrit Notification Bot 2014-03-06 15:49:46 UTC
Change 117154 merged by jenkins-bot:
Delete stub l10n file after generating ExtensionMessages

https://gerrit.wikimedia.org/r/117154
Comment 19 Gerrit Notification Bot 2014-03-06 18:01:04 UTC
Change 117236 had a related patch set uploaded by BryanDavis:
Remove l10n file as user l10nupdate

https://gerrit.wikimedia.org/r/117236
Comment 20 Gerrit Notification Bot 2014-03-06 18:04:13 UTC
Change 117236 merged by jenkins-bot:
Remove l10n file as user l10nupdate

https://gerrit.wikimedia.org/r/117236
Comment 21 Bryan Davis 2014-03-06 20:27:27 UTC
It worked!
Comment 22 Bryan Davis 2014-03-06 21:11:05 UTC
Or not:

14:03]  <    bd808>	 greg-g: Nemo_bis found an l10n bug in wmf17 -- https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures
[14:03]  <      huh>	 [MatmaRex]
[14:04]  < MatmaRex>	 [21:58]    <huh> Did I add i18n for sp-contributions-newonly correctly? :/
[14:04]  < MatmaRex>	 [21:59]    <huh> It looks ok here http://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Contributions/108.32.45.153
[14:04]  < MatmaRex>	 [21:59]    <huh> but broken here https://www.mediawiki.org/wiki/Special:Contributions/PiRSquared17
Comment 23 Bryan Davis 2014-03-07 17:18:46 UTC
It just dawned on me that rebuildLocalisationCache.php has a `--force` option. This might be the answer rather than the attempts that I've made to clean up after the stub l10n generation.
Comment 24 Gerrit Notification Bot 2014-03-10 03:35:20 UTC
Change 117821 had a related patch set uploaded by BryanDavis:
Force l10n rebuild after bootstrapping

https://gerrit.wikimedia.org/r/117821
Comment 25 Gerrit Notification Bot 2014-03-13 14:50:16 UTC
Change 117821 merged by jenkins-bot:
Force l10n rebuild after bootstrapping

https://gerrit.wikimedia.org/r/117821
Comment 26 Bryan Davis 2014-03-13 21:24:19 UTC
I'm going to declare victory on this now. I added the `--force` flag and the only l10n issues that have been reported against the 1.23wmf18 branch were due to an unrelated partial scap failure.
Comment 27 Nemo 2014-04-04 20:59:18 UTC
(In reply to Bryan Davis from comment #26)
> I'm going to declare victory on this now.

Or not: https://wikitech.wikimedia.org/wiki/Incident_documentation/20140403-Deploy#Bryan

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links