Last modified: 2013-08-23 23:08:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53198, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51198 - Don't use autoInserted* markers in the serializer unless in round-trip mode
Don't use autoInserted* markers in the serializer unless in round-trip mode
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-11 21:12 UTC by Gabriel Wicke
Modified: 2013-08-23 23:08 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-07-11 21:12:03 UTC
Apparendly autoInserted* markers are still used in the serializer for HTML tags even when we are not round-trip testing. This is unsafe, so should be disabled.

We can however safely clean up some things in the DOMPostProcessor based on these tags.
Comment 1 Kelson [Emmanuel Engelhart] 2013-08-23 10:27:22 UTC
Does this bug explains why we have such type of HTML 

</span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}' about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2" data-parsoid="{}">
</span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}' about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2" data-parsoid="{}">
</span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}' about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2" data-parsoid="{}">
</span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}' about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2" data-parsoid="{}">
</span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}' about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2" data-parsoid="{}">

... at the top of many article, like this one for example?
http://parsoid.wmflabs.org/fi/Kypros
Comment 2 Gabriel Wicke 2013-08-23 23:08:18 UTC
(In reply to comment #1)
> Does this bug explains why we have such type of HTML 
> 
> </span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}'
> about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2"
> data-parsoid="{}">
> </span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}'
> about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2"
> data-parsoid="{}">
> </span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}'
> about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2"
> data-parsoid="{}">
> </span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}'
> about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2"
> data-parsoid="{}">
> </span><p data-parsoid='{"fostered":true,"autoInsertedEnd":true}'
> about="#mwt2"><br data-parsoid="{}"></p><span about="#mwt2"
> data-parsoid="{}">
> 
> ... at the top of many article, like this one for example?
> http://parsoid.wmflabs.org/fi/Kypros

No, that is not related. There is a bug though, which I described in bug 53287.

The original bug has since been fixed by making editMode the default everywhere except in round-trip testing. Closing this bug for that reason.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links