Last modified: 2014-07-24 21:47:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53222, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51222 - html2wt: ISBN numbers are not being nowikied properly
html2wt: ISBN numbers are not being nowikied properly
Status: NEW
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Parsoid Team
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-12 08:57 UTC by Spinningspark
Modified: 2014-07-24 21:47 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Spinningspark 2013-07-12 08:57:35 UTC
I just tried doing a ref through VisEd for the first time.  I typed the ref manually, that is, without using a template.  VisEd surrounded the whole ref with <nowiki> tags so that the ref was not rendered correctly.  Probably I should have used the VisEd buttons for the italics and bolding (I will try that next time), but what about the ISBN number?  "ISBN" is a magic word and this should continue to work through VisEd to render the ISBN number as a link.
Comment 1 James Forrester 2013-07-12 22:56:22 UTC
This is worrying - I can't reproduce this as you describe (the auto-link works fine and is not wrapped in <nowiki>s). Can you give more details? Did you save the page - if so, do you have the diff link? What browser were you using?
Comment 2 Spinningspark 2013-07-13 11:34:49 UTC
http://en.wikipedia.org/w/index.php?title=Siemens_%28unit%29&diff=prev&oldid=563930491

Firefox 22.0
Windows 7 Home Premium SP1 64-bit
Dell Inspiron 660
Intel Core i3-2120
Comment 3 James Forrester 2013-07-13 13:57:45 UTC
(In reply to comment #2)
> http://en.wikipedia.org/w/index.
> php?title=Siemens_%28unit%29&diff=prev&oldid=563930491
> 
> Firefox 22.0
> Windows 7 Home Premium SP1 64-bit
> Dell Inspiron 660
> Intel Core i3-2120

Aha - did you type in "Applications of Environmental Aquatic Chemistry: A Practical Guide" and then make it italics, or did you try to use wikitext to 
do this, typing in "''Applications of Environmental Aquatic Chemistry: A Practical Guide''"?

If the latter, I think this bug can be simplified to "ISBN 1234567890 should be spotted when avoiding overly-keen <nowiki>ing - is that correct?
Comment 4 Spinningspark 2013-07-13 14:09:54 UTC
That seems to about sum it up.  As I said in my initial post, the bold and italics not rendering are probably my own fault.
Comment 5 James Forrester 2013-07-13 14:12:07 UTC
(In reply to comment #4)
> That seems to about sum it up.  As I said in my initial post, the bold and
> italics not rendering are probably my own fault.

OK, retitling. :-)
Comment 6 ssastry 2014-07-24 21:47:56 UTC
Is it correct to summarize this as a bug in the serializer where ISBN text is not being nowikied?

[subbu@earth lib] echo "<p>ISBN 1234567890</p>" | node parse --html2wt
ISBN 1234567890

whereas the expected output should have been:
<nowiki>ISBN 1234567890</nowiki>

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links