Last modified: 2014-07-30 00:45:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53243, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51243 - VisualEditor: If making a null change, the "Your edit was saved" message appears, even if there were no changes and so it wasn't
VisualEditor: If making a null change, the "Your edit was saved" message appe...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2014-07-31
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-12 15:47 UTC by Elitre
Modified: 2014-07-30 00:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Elitre 2013-07-12 15:47:30 UTC
I was following Sherry's kind advices in my sandbox at enwp http://en.wikipedia.org/wiki/User:Elitre_(WMF)/Sandbox:
<<you can create an {{Infobox person}}, with parameters like "name" and "occupation".  Within those parameters, you can type the wikicode for any templates you want.  For example, you can give it a name parameter of "Alice Expert((citation needed|date=July 2013}}", which later gets processed properly as a template. >>
An infobox appeared (well, a box with my sandbox title, actually), I saved, "your edit was saved" message appeared, the box isn't in the page anymore.
Tried again, same thing. No trace of my activity in the history. Win 7, Vector, both Chrome and FF.

Thanks,
E.
Comment 1 Elitre 2013-07-12 15:49:32 UTC
It must be the "template within a template" thing, because it will save without that part. 
Thanks,
E.
Comment 2 Elitre 2013-07-12 16:57:03 UTC
It might be worth adding that this actually works for Sherry:
http://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&action=history .
Comment 3 James Forrester 2013-11-25 17:15:07 UTC
This is the same behaviour as the wikitext editor. We really should fix this there first if we're changing behaviour for VisualEditor, so that they match.

CC'ed Steven - is there interest in changing for this case in core?
Comment 4 Steven Walling 2013-11-25 19:09:39 UTC
(In reply to comment #3)
> This is the same behaviour as the wikitext editor. We really should fix this
> there first if we're changing behaviour for VisualEditor, so that they match.
> 
> CC'ed Steven - is there interest in changing for this case in core?

As far as I know, this problem is solved for the wikitext editor. We should not be showing the post-edit confirmation on null edits. I just re-tested this to confirm with a null edit to an article. Is there something special about Elitre's case that I should try to replicate?
Comment 5 James Forrester 2014-06-05 19:51:51 UTC
Confirmed that this is still broken for VisualEditor (and not for wikitext editing).
Comment 6 Gerrit Notification Bot 2014-07-29 22:41:13 UTC
Change 150419 had a related patch set uploaded by Alex Monk:
Don't show PostEdit message if we made a null edit.

https://gerrit.wikimedia.org/r/150419
Comment 7 Gerrit Notification Bot 2014-07-30 00:45:12 UTC
Change 150419 merged by jenkins-bot:
Don't show PostEdit message if we made a null edit

https://gerrit.wikimedia.org/r/150419

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links