Last modified: 2013-08-15 15:17:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53253, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51253 - VisualEditor: Remove obsolete retry token logic in mw.Target
VisualEditor: Remove obsolete retry token logic in mw.Target
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-08-15
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-12 18:49 UTC by Krinkle
Modified: 2013-08-15 15:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-07-12 18:49:39 UTC 

    


      




        
          Comment 1
        

        
          Krinkle

        

        
        

        
          2013-07-12 18:50:01 UTC
        
      





onLoad no longer requires or even considers a token, so this is now obsolete.

    


      




        
          Comment 2
        

        
          Krinkle

        

        
        

        
          2013-07-12 18:50:53 UTC
        
      





It also ignored the fact that the new token may be logged out or for a different user, though this was previous OK-ish because it was only to load the content which is a read action and not a write action (hence why we fixed that API recently to no longer require a token)

    


      




        
          Comment 3
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-07-31 00:45:29 UTC
        
      





Change 76860 had a related patch set uploaded by Krinkle:
Removed unreachable badtoken recovery code

https://gerrit.wikimedia.org/r/76860

    


      




        
          Comment 4
        

        
          Gerrit Notification Bot

        

        
        

        
          2013-08-15 08:40:10 UTC
        
      





Change 76860 merged by jenkins-bot:
mw.Target: Removed unreachable badtoken recovery code

https://gerrit.wikimedia.org/r/76860

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links