Last modified: 2013-07-16 17:39:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53255, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51255 - Parsoid only changes the first '*' to '#' when a <ul> is a changed to an <ol>
Parsoid only changes the first '*' to '#' when a <ul> is a changed to an <ol>
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: ssastry
https://test.wikipedia.org/wiki/User:...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-12 19:19 UTC by Raimond Spekking
Modified: 2013-07-16 17:39 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2013-07-12 19:19:18 UTC 
Changing all items of an ordered or unordered list does change the first item only

Steps to reproduce:

1. Mark all items of an ordered (ol) or unordered list (ul) (see URL)
2. Click on the icon in the toolbar to change from ol to ul (or vice versa)
3. The rendering changes as expected
4. Really changed is only the first list item, https://test.wikipedia.org/w/index.php?title=User:Raymond/ol2ul&diff=175507&oldid=175506
Comment 1 Roan Kattouw 2013-07-12 19:31:54 UTC 
This is a Parsoid bug. VE changes the <ul> to an <ol> (or v.v.) but Parsoid only reserializes the first item. Presumably selser tries to avoid reserializing the <li>s inside the list because they haven't changed.
Comment 2 ssastry 2013-07-15 15:30:10 UTC 
That is weird -- selser should have handled this properly since the whole subtree is considered modified and would have been serialized using the regular serializer.  Investigating.
Comment 3 Gerrit Notification Bot 2013-07-15 15:37:17 UTC 
Change 73761 had a related patch set uploaded by Subramanya Sastry:
(Bug 51255) Fix selser bug handling subtrees marked 'modified'

https://gerrit.wikimedia.org/r/73761
Comment 4 Gerrit Notification Bot 2013-07-16 16:07:17 UTC 
Change 73761 merged by jenkins-bot:
(Bug 51255) Fix selser bug handling subtrees marked 'modified'

https://gerrit.wikimedia.org/r/73761
Comment 5 ssastry 2013-07-16 17:39:11 UTC 
To be deployed (rt-testing wont exercise this code).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links