Last modified: 2014-02-04 22:52:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53262, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51262 - Render paragraphs when indent-pre is suppressed in blocklevels such as blockquote
Render paragraphs when indent-pre is suppressed in blocklevels such as blockq...
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-12 21:30 UTC by Gabriel Wicke
Modified: 2014-02-04 22:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-07-12 21:30:55 UTC 
Test case:

<blockquote>
  foo

  bar
</blockquote>

Expected result:
Two paragraphs (yeah, broken in PHP, but that is discussed in bug 51087).

Actual result:
No paragraph at all, likely due to indent-p / paragraph wrapper interaction.
Comment 1 Gabriel Wicke 2013-07-12 21:32:26 UTC 
The PHP parser discussion is actually bug 51086.
Comment 2 C. Scott Ananian 2013-07-12 21:37:12 UTC 
Note that:
<blockquote>
foo

bar
</blockquote>

works already.  It's just the leading-indent version which doesn't -- because the <pre> tags get stripped inside the blockquote in a later stage.
Comment 3 C. Scott Ananian 2013-08-12 18:46:11 UTC 
Might be related to bug 52761.

Note that the PHP parser creates <pre>s for the test case specified in the description now.
Comment 4 C. Scott Ananian 2013-08-15 21:13:54 UTC 
PHP fix is actually bug 6200.  And there are no <pre>s from the PHP parser now.
Comment 5 C. Scott Ananian 2013-08-15 21:21:47 UTC 
I think subbu was hacking on the indent-pre stuff recently.
Comment 6 Gerrit Notification Bot 2014-01-31 23:08:59 UTC 
Change 110651 had a related patch set uploaded by Arlolra:
Render paragraphs when indent-pre is suppressed in blocklevels

https://gerrit.wikimedia.org/r/110651
Comment 7 Gerrit Notification Bot 2014-02-04 22:36:21 UTC 
Change 110651 merged by jenkins-bot:
Render paragraphs when indent-pre is suppressed in blocklevels

https://gerrit.wikimedia.org/r/110651
Comment 8 Arlo Breault 2014-02-04 22:52:44 UTC 
The original test case was fixed here: https://git.wikimedia.org/commit/mediawiki%2Fservices%2Fparsoid.git/12405fbcd0ba39a889914613d828934d9482c721

but we still need to investigate the PHP parser's behaviour for other blocklevels besides blockquote.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links