Last modified: 2013-08-05 16:31:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53322, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51322 - VisualEditor: Handle 'meta' templates better
VisualEditor: Handle 'meta' templates better
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-07-25
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-14 14:03 UTC by Ed Sanders
Modified: 2013-08-05 16:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-07-14 14:03:42 UTC
Some templates are only used to include metadata, e.g. categories. In this example http://en.wikipedia.org/w/index.php?title=Ashton_Agar&oldid=564224425&veaction=edit the document starts with two such categories, producing linebreak characters, with templates spanning 0 characters in between (accessible still be cursoring). An uninitiated user may just decide to delete this whole line at the the top, thus removing the hidden templates.

Perhaps we need to detect if a template contains no meaningful content and then move it into the metadata so it can't be accidentally deleted. We'd also need a UI for editing them though.
Comment 1 John Mark Vandenberg 2013-07-18 08:11:17 UTC
To help searching: the cited examples are {{Use dmy dates}} and {{Use Australian English}}.

Increasing importance/priority because they can be deleted unintentionally, and it is very unlikely a new user will know how to add them back before they click save.
Comment 2 John Mark Vandenberg 2013-07-18 08:14:08 UTC
Another example given on WP:VEF is {{Link FA}}
Comment 3 John Mark Vandenberg 2013-07-21 23:00:14 UTC

*** This bug has been marked as a duplicate of bug 49806 ***
Comment 4 Ed Sanders 2013-07-23 13:41:49 UTC
This is not the same as bug 51420. This specifically concerns templates which only produce 'metadata' in the VE-data-model meaning of the term.
Comment 5 Gerrit Notification Bot 2013-07-23 13:42:10 UTC
Change 75331 had a related patch set uploaded by Esanders:
Handle meta-only transculsions as meta items

https://gerrit.wikimedia.org/r/75331
Comment 6 John Mark Vandenberg 2013-07-23 18:30:32 UTC
I marked this as a dup of bug 49806, not dup of 51420.
Comment 7 Gerrit Notification Bot 2013-07-24 14:29:22 UTC
Change 75331 merged by jenkins-bot:
Handle meta-only transclusions as meta items

https://gerrit.wikimedia.org/r/75331
Comment 8 James Forrester 2013-07-24 14:39:12 UTC
Fixed and will get deployed in a few minutes.
Comment 9 Derk-Jan Hartman 2013-08-05 16:31:41 UTC
Additional issue with empty HTML elements produced by templates (which are used for metadata) in bug 52551.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links