Last modified: 2013-07-15 17:13:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53342, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51342 - API prop=imageinfo is not returning correct iicontinue when image title is not the same as the dbkey
API prop=imageinfo is not returning correct iicontinue when image title is no...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.22.0
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-15 07:33 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-07-15 17:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rainer Rillke @commons.wikimedia 2013-07-15 07:33:15 UTC
When querying imageinfo 
* for multiple titles
  (When requesting just one title, it uses iistart for query-continuation.)
* with thumburl requested
* for a file with more revisions than the API will output thumburls
the API returns a query-continue that, when used will return the same results and the same query-continue:

https://commons.wikimedia.org/w/api.php?format=jsonfm&action=query&prop=imageinfo&iiprop=url&titles=File:Susy%20Zerfall%20chi0.svg|File:Samesex%20marriage%20in%20USA.svg&iiurlwidth=120&iilimit=500&iicontinue=Samesex%20marriage%20in%20USA.svg|20110701173547

which gives:
{
    "query-continue": {
        "imageinfo": {
            "iicontinue": "Samesex marriage in USA.svg|20110701173547"
        }
    },
    "query": {
        "pages": {
...



My client picks-up the 
"iicontinue": "Samesex marriage in USA.svg|20110701173547" 
and sends it back to the API.
Comment 1 Rainer Rillke @commons.wikimedia 2013-07-15 11:33:41 UTC
Why is this of low priority? If many clients use a similar query you DDoS yourself.
Comment 2 Rainer Rillke @commons.wikimedia 2013-07-15 15:16:57 UTC
Perhaps I should explicitly mention that I do not get the data I requested?
Comment 3 Brad Jorsch 2013-07-15 15:20:43 UTC
More specifically, the bug appears to be that it is not paying attention to the iicontinue value at all. The same results are being returned whether iicontinue is passed or not.
Comment 4 Brad Jorsch 2013-07-15 15:39:21 UTC
Ok, I've tracked it down. Gerrit change to be posted shortly.
Comment 5 Gerrit Notification Bot 2013-07-15 15:43:06 UTC
Change 73762 had a related patch set uploaded by Anomie:
API: Fix prop=imageinfo iicontinue

https://gerrit.wikimedia.org/r/73762
Comment 6 Rainer Rillke @commons.wikimedia 2013-07-15 15:48:03 UTC
Thank you. That was fast.
Comment 7 Gerrit Notification Bot 2013-07-15 17:08:58 UTC
Change 73762 merged by jenkins-bot:
API: Fix prop=imageinfo iicontinue

https://gerrit.wikimedia.org/r/73762
Comment 8 Brad Jorsch 2013-07-15 17:13:20 UTC
Change is now merged. It should be deployed on WMF wikis along with 1.22wmf11, see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links