Last modified: 2013-07-26 15:08:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53363, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51363 - Dispatcher chokes on specific changes
Dispatcher chokes on specific changes
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Immediate critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-15 12:24 UTC by denny vrandecic
Modified: 2013-07-26 15:08 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description denny vrandecic 2013-07-15 12:24:48 UTC
Changes that merely change the order of sitelinks (and maybe others) lead to the dispatcher choking and not moving forward. Here's the analysis by Katie:

After investigating on toollabs with the copy of the wikidata database there, it looks like change id 55754448 is the odd one:

http://dpaste.com/1300944/

http://www.wikidata.org/w/index.php?title=Q13360583&diff=57098298&oldid=54370606

For that change, DiffChange->getDiff() (and getSiteLinkDiff) are returning a DiffOpChange object.  For all other changes, it is an ItemDiff object.

The site link diff involves changing the order of the site links in the array, but otherwise a null change for site links:

Diff\DiffOpChange::__set_state(array(
   'newValue' => 
  array (
    'svwiki' => 'Projekt 661 Antjar',
    'dewiki' => 'Papa-Klasse',
    'frwiki' => 'Classe Papa',
    'cswiki' => 'Projekt 661',
  ),
   'oldValue' => 
  array (
    'cswiki' => 'Projekt 661',
    'dewiki' => 'Papa-Klasse',
    'frwiki' => 'Classe Papa',
    'svwiki' => 'Projekt 661 Antjar',
  ),
))
Comment 1 Gerrit Notification Bot 2013-07-15 13:22:58 UTC
Change 73752 had a related patch set uploaded by Daniel Kinzler:
(bug 51363) Fix MapDiffer for equivalent substructs.

https://gerrit.wikimedia.org/r/73752
Comment 2 Gerrit Notification Bot 2013-07-15 15:44:46 UTC
Change 73763 had a related patch set uploaded by Daniel Kinzler:
(bug 51363) Work around broken diffs.

https://gerrit.wikimedia.org/r/73763
Comment 3 Gerrit Notification Bot 2013-07-15 16:21:13 UTC
Change 73772 had a related patch set uploaded by Daniel Kinzler:
(bug 51363) Add more tests to for bad diffs.

https://gerrit.wikimedia.org/r/73772
Comment 4 Gerrit Notification Bot 2013-07-15 21:55:27 UTC
Change 73752 merged by Jeroen De Dauw:
(bug 51363) Fix MapDiffer for equivalent substructs.

https://gerrit.wikimedia.org/r/73752
Comment 5 Gerrit Notification Bot 2013-07-15 22:02:23 UTC
Change 73763 merged by Jeroen De Dauw:
(bug 51363) Work around broken diffs.

https://gerrit.wikimedia.org/r/73763
Comment 6 abraham.taherivand 2013-07-17 14:31:17 UTC
Verified in Wikidata demo time July 17th
Comment 7 Gerrit Notification Bot 2013-07-26 15:08:34 UTC
Change 73772 merged by jenkins-bot:
(bug 51363) Add more tests to for bad diffs.

https://gerrit.wikimedia.org/r/73772

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links