Last modified: 2013-07-26 15:08:34 UTC
Changes that merely change the order of sitelinks (and maybe others) lead to the dispatcher choking and not moving forward. Here's the analysis by Katie: After investigating on toollabs with the copy of the wikidata database there, it looks like change id 55754448 is the odd one: http://dpaste.com/1300944/ http://www.wikidata.org/w/index.php?title=Q13360583&diff=57098298&oldid=54370606 For that change, DiffChange->getDiff() (and getSiteLinkDiff) are returning a DiffOpChange object. For all other changes, it is an ItemDiff object. The site link diff involves changing the order of the site links in the array, but otherwise a null change for site links: Diff\DiffOpChange::__set_state(array( 'newValue' => array ( 'svwiki' => 'Projekt 661 Antjar', 'dewiki' => 'Papa-Klasse', 'frwiki' => 'Classe Papa', 'cswiki' => 'Projekt 661', ), 'oldValue' => array ( 'cswiki' => 'Projekt 661', 'dewiki' => 'Papa-Klasse', 'frwiki' => 'Classe Papa', 'svwiki' => 'Projekt 661 Antjar', ), ))
Change 73752 had a related patch set uploaded by Daniel Kinzler: (bug 51363) Fix MapDiffer for equivalent substructs. https://gerrit.wikimedia.org/r/73752
Change 73763 had a related patch set uploaded by Daniel Kinzler: (bug 51363) Work around broken diffs. https://gerrit.wikimedia.org/r/73763
Change 73772 had a related patch set uploaded by Daniel Kinzler: (bug 51363) Add more tests to for bad diffs. https://gerrit.wikimedia.org/r/73772
Change 73752 merged by Jeroen De Dauw: (bug 51363) Fix MapDiffer for equivalent substructs. https://gerrit.wikimedia.org/r/73752
Change 73763 merged by Jeroen De Dauw: (bug 51363) Work around broken diffs. https://gerrit.wikimedia.org/r/73763
Verified in Wikidata demo time July 17th
Change 73772 merged by jenkins-bot: (bug 51363) Add more tests to for bad diffs. https://gerrit.wikimedia.org/r/73772