Last modified: 2013-07-16 00:14:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53399, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51399 - WikiLove creates pages like User talk:User talk:Subject
WikiLove creates pages like User talk:User talk:Subject
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiLove (Other open bugs)
REL1_21-branch
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-15 21:07 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-07-16 00:14 UTC (History)
4 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Rainer Rillke @commons.wikimedia 2013-07-15 21:12:28 UTC
How to reproduce:
* Go to https://commons.wikimedia.org/wiki/User:RillkeBot
* Send the message:

POST /w/api.php
action	wikilove
format	json
message	Test
subject	A beer for you!
text	{| style="background-color: #fdffe7; border: 1px solid #fceb92;" |style="vertical-align: middle; padding: 5px;" | [[File:Export hell seidel steiner.png|70px]] |style="vertical-align: middle; padding: 3px;" | Test ~~~~ |}
title	User:User:RillkeBot
token	XXX
type	food-beer

Response:
{"redirect":{"pageName":"User_talk:User:RillkeBot","fragment":"A_beer_for_you.21"}}
Comment 2 MZMcBride 2013-07-15 21:21:06 UTC
(In reply to comment #1)
> title    User:User:RillkeBot

This isn't a valid title. Garbage in, garbage out?
Comment 3 Rainer Rillke @commons.wikimedia 2013-07-15 21:30:40 UTC
(In reply to comment #2)
> This isn't a valid title. Garbage in, garbage out?
This may be true but the user does not set the title. This is done by the javascript interface of the extension.
Comment 4 MZMcBride 2013-07-15 21:34:43 UTC
Sorry, I got confused and thought you were manually POSTing. I just confirmed that the interface is broken: <https://commons.wikimedia.org/w/index.php?title=User_talk:User:RillkeBot&oldid=100086116>.

Was Commons recently updated? Perhaps related to MediaWiki 1.22wmf10.
Comment 5 MZMcBride 2013-07-15 21:36:36 UTC
Also appears to be broken on test.wikipedia.org: <https://test.wikipedia.org/wiki/User_talk:User:Legoktm#A_kitten_for_you.21>. Hrmph.
Comment 6 Ryan Kaldari 2013-07-15 21:43:30 UTC
Looks like it's probably due to https://gerrit.wikimedia.org/r/#/c/64883
Comment 7 Gerrit Notification Bot 2013-07-15 21:56:49 UTC
Change 73871 had a related patch set uploaded by Kaldari:
Reverting change I6d2fa445 to fix regression.

https://gerrit.wikimedia.org/r/73871
Comment 8 Gerrit Notification Bot 2013-07-15 21:57:18 UTC
Change 73871 merged by jenkins-bot:
Reverting change I6d2fa445 to fix regression.

https://gerrit.wikimedia.org/r/73871
Comment 9 Brad Jorsch 2013-07-15 22:07:13 UTC
(In reply to comment #6)
> Looks like it's probably due to https://gerrit.wikimedia.org/r/#/c/64883

It looks to me like that didn't cause it, it just exposed it. The real problem lies in the Javascript, where it blindly prepends "User:" to each item in the recipients list (ext.wikiLove.core.js line 705) even though the one entry in the default recipient list (ext.wikiLove.core.js line 34) already begins with "User".
Comment 10 Gerrit Notification Bot 2013-07-15 22:22:44 UTC
Change 73883 had a related patch set uploaded by Hoo man:
Don't construct titles like User:User:Hoo in JS

https://gerrit.wikimedia.org/r/73883
Comment 11 Gerrit Notification Bot 2013-07-16 00:14:06 UTC
Change 73883 merged by jenkins-bot:
Don't construct titles like User:User:Hoo in JS

https://gerrit.wikimedia.org/r/73883

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links