Last modified: 2013-12-03 23:09:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53448, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51448 - ParserTests: incrementally rewrite-blacklist when used with --filter option
ParserTests: incrementally rewrite-blacklist when used with --filter option
Status: REOPENED
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-16 16:43 UTC by ssastry
Modified: 2013-12-03 23:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description ssastry 2013-07-16 16:43:38 UTC 
when --filter and --rewrite-blacklist is used together, rewrite deletes entries for all other tests. Fix parser tests script to make them play well together.
Comment 1 C. Scott Ananian 2013-07-16 17:26:42 UTC 
The easiest thing would be for --rewrite-blacklist to fail with an error if --filter was specified.

But you want something different, it seems?  To keep all the existing blacklist entries which don't match the filter, and just rewrite the filtered ones?
Comment 2 ssastry 2013-07-16 17:36:02 UTC 
The former would be good, and the latter would be better.  It can even be two different tasks.
Comment 3 Gerrit Notification Bot 2013-07-16 18:02:55 UTC 
Change 73984 had a related patch set uploaded by Cscott:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984
Comment 4 Gerrit Notification Bot 2013-07-16 18:40:24 UTC 
Change 73984 merged by jenkins-bot:
Sanity check --rewrite-blacklist: don't allow simultaneous --filter.

https://gerrit.wikimedia.org/r/73984
Comment 5 C. Scott Ananian 2013-08-16 16:58:45 UTC 
Retitling the bug to accomodate the second half of subbu's feature request.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links