Last modified: 2013-08-25 16:30:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53463, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51463 - VisualEditor: Don't extend links over wordbreaks
VisualEditor: Don't extend links over wordbreaks
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-07-25
Assigned To: Ed Sanders
:
: 51531 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-16 19:11 UTC by Ed Sanders
Modified: 2013-08-25 16:30 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-07-16 19:11:07 UTC
With bug 49931 we currently extend link annotations when typing at the end. This makes it very difficult to type plain text after a link at the end of a paragraph.

We should change the logic to stop extending the annotation once a character is added that produces a new wordbreak.

There may be some odd cases as wordbreak logic can depend on more that two characters, e.g. a' has a wordbreak but a's doesn't, so trying to add "'s" to the end of a link label would break after the "'" even though it wouldn't if "'s" was added as one operation.
Comment 1 Gerrit Notification Bot 2013-07-17 15:59:20 UTC
Change 74168 had a related patch set uploaded by Esanders:
[WIP] Split continued link annotations on wordbreaks

https://gerrit.wikimedia.org/r/74168
Comment 2 Gerrit Notification Bot 2013-07-24 14:43:47 UTC
Change 74168 merged by jenkins-bot:
Split continued link annotations on wordbreaks

https://gerrit.wikimedia.org/r/74168
Comment 3 James Forrester 2013-07-24 14:45:10 UTC
Fixed and will get deployed in a few minutes.
Comment 4 James Forrester 2013-07-24 15:23:17 UTC
*** Bug 51531 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links