Last modified: 2014-10-01 12:50:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53539, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51539 - Mediawiki no longer accepts unicode object property name without quotes
Mediawiki no longer accepts unicode object property name without quotes
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.22.0
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-17 15:21 UTC by Siddhartha Ghai
Modified: 2014-10-01 12:50 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siddhartha Ghai 2013-07-17 15:21:41 UTC
This [1] revision of the gadget Twinkle on hi-wp gave the browser exception:

Exception thrown by ext.gadget.Twinkle: JavaScript parse error: Parse error: Illegal token in file 'MediaWiki:Gadget-Twinkle.js' on line 3757

In the next revision [2] of Twinkle, the problem was not there. The only change made to resolve this were that object property names starting with devanagari characters were put into quotes. E.g.:

 शीह: "विशिष्ट कारण ({{शीह}})",

was changed to

 "शीह": "विशिष्ट कारण ({{शीह}})",

Although this has gotten twinkle up and running, I don't see why RL generated the exception in the first place. Devanagari characters are already specified in Unicode 3.0 and hence are good for starting property names as per ECMA-262(if I read the standard correctly).

Further details may be found in [3].

[1]: http://hi.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Gadget-Twinkle.js&oldid=2175350

[2]: http://hi.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF:Gadget-Twinkle.js&oldid=2176139

[3]: https://bugzilla.wikimedia.org/show_bug.cgi?id=51361#c3
Comment 1 Siddhartha Ghai 2013-07-17 16:14:44 UTC
As far as I can see from [1], [2] and [3], this shouldn't be happening.

[1]: Bug 31187
[2]: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98281
[3]: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/98285
Comment 2 Andre Klapper 2013-07-18 11:13:43 UTC
As you write "no longer", any idea when using quotes still worked?
Comment 3 Siddhartha Ghai 2013-07-24 00:18:25 UTC
Well, I know that TW still worked back in February 13. This diff [1] was by TW on 24 Feb. Its the newest I could find before it broke. I think its probably got something to do with the jsmin+ unicode fix not working properly.

[1]: http://hi.wikipedia.org/w/index.php?title=%E0%A4%B5%E0%A4%BF%E0%A4%95%E0%A4%BF%E0%A4%AA%E0%A5%80%E0%A4%A1%E0%A4%BF%E0%A4%AF%E0%A4%BE:%E0%A4%85%E0%A4%A8%E0%A5%81%E0%A4%B5%E0%A4%BE%E0%A4%A6_%E0%A4%85%E0%A4%A8%E0%A5%81%E0%A4%B0%E0%A5%8B%E0%A4%A7&diff=prev&oldid=2090806

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links