Last modified: 2014-02-12 23:55:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53550, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51550 - Title jumps on open
Title jumps on open
Status: RESOLVED INVALID
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Lowest normal
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-17 16:30 UTC by Jon
Modified: 2014-02-12 23:55 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Before (39.47 KB, image/png)
2013-07-18 19:11 UTC, Jon
Details
After (24.38 KB, image/png)
2013-07-18 19:11 UTC, Jon
Details
Would hiding the text under the edit button be a terrible thing...? (41.59 KB, image/png)
2013-07-19 01:44 UTC, Jon
Details

Description Jon 2013-07-17 16:30:05 UTC
Go to http://en.m.wikipedia.org/wiki/Douglas_Engelbart (logged out view)
Set the device width to 320px

Expand "Early life and education"
The heading jumps down to a second row.

Expected:
It shouldn't jump down
Comment 1 Gerrit Notification Bot 2013-07-18 17:50:54 UTC
Change 74395 had a related patch set uploaded by Jdlrobson:
Bug 51550: Always set padding right

https://gerrit.wikimedia.org/r/74395
Comment 2 Jon 2013-07-18 19:11:21 UTC
Created attachment 12885 [details]
Before
Comment 3 Jon 2013-07-18 19:11:40 UTC
Created attachment 12886 [details]
After
Comment 4 Jon 2013-07-18 19:11:52 UTC
Brought Brandon into this discussion - as Juliusz pointed out there are two ways of looking at this

* The edit icon is not shown when the section is toggled thus there is available whitespace and not taking up that available whitespace is weird
* The last word of the title jumping is jarring - your attention is immediately drawn to the word below the section. This is also weird.

We can not stop the jumping for anon users but it does feel like it would be better to show some visual indicator that an edit icon will appear there.

Is there a good reason we don't always show the edit icon to logged in users (just possibly gray it out until the content is visible?)
Comment 5 Jon 2013-07-19 01:44:24 UTC
Created attachment 12890 [details]
Would hiding the text under the edit button be a terrible thing...?
Comment 6 Gerrit Notification Bot 2013-07-24 18:59:47 UTC
Change 74395 abandoned by Jdlrobson:
Bug 51550: Always set padding right

Reason:
Abandoning this for time being until we have some consensus.. (although bear in mind I still think current behaviour is very wrong and bugs me :-)!)

https://gerrit.wikimedia.org/r/74395
Comment 7 Jon 2013-08-14 18:57:37 UTC
Any suggestions of what to do on this if anything? Maryana?
Comment 8 Jon 2013-08-19 22:11:06 UTC
This will be fixed by implementing https://mingle.corp.wikimedia.org/projects/mobile/cards/1092
Comment 9 Jon 2013-08-23 17:44:50 UTC
No longer a valid bug CTA is now always shown.
Comment 10 Jon 2013-08-23 17:45:20 UTC
(reference: https://gerrit.wikimedia.org/r/80298 )

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links